◐ Shell
reader mode source ↗
Skip to content

bpo-36983: Fix typing.__all__ and add test for exported names#13456

Merged
miss-islington merged 1 commit into
python:masterfrom
asottile:typing_all_bpo-36983
May 29, 2019
Merged

bpo-36983: Fix typing.__all__ and add test for exported names#13456
miss-islington merged 1 commit into
python:masterfrom
asottile:typing_all_bpo-36983

Conversation

@asottile

@asottile asottile commented May 21, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@Carreau

Carreau commented May 29, 2019

Copy link
Copy Markdown
Contributor

(also will need a rebase/fix conflicts.)

@asottile asottile force-pushed the typing_all_bpo-36983 branch from cb7699d to 587dc7a Compare May 29, 2019 03:40
@miss-islington miss-islington merged commit d30da5d into python:master May 29, 2019
@miss-islington

miss-islington commented May 29, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

1 similar comment
@miss-islington

miss-islington commented May 29, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington

miss-islington commented May 29, 2019

Copy link
Copy Markdown
Contributor

Thanks @asottile for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented May 29, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Will retry in 1 minute. Retry # 1

@asottile asottile deleted the typing_all_bpo-36983 branch May 29, 2019 18:59
@bedevere-bot

bedevere-bot commented May 29, 2019

Copy link
Copy Markdown

GH-13662 is a backport of this pull request to the 3.7 branch.

asottile added a commit to asottile/cpython that referenced this pull request May 29, 2019
@asottile
bpo-36983: Fix typing.__all__ and add test for exported names (python… …
076236c 
…GH-13456)

https://bugs.python.org/issue36983
@bedevere-bot

bedevere-bot commented May 29, 2019

Copy link
Copy Markdown

GH-13663 is a backport of this pull request to the 3.6 branch.

asottile added a commit to asottile/cpython that referenced this pull request May 29, 2019
@asottile
bpo-36983: Fix typing.__all__ and add test for exported names (python… …
cb74eb5 
…GH-13456)

https://bugs.python.org/issue36983
miss-islington pushed a commit that referenced this pull request May 30, 2019
@asottile @miss-islington
[3.7] bpo-36983: Fix typing.__all__ and add test for exported names (G… …
3a98bbf 
…H-13456) (GH-13662)

https://bugs.python.org/issue36983

Fixes issue 36983
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asottile @DinoV
bpo-36983: Fix typing.__all__ and add test for exported names (python… …
e202da1 
…GH-13456)

https://bugs.python.org/issue36983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

+1 more reviewer

@Carreau Carreau

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@asottile @Carreau @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni