gh-134861: Add CSV output format to asyncio ps#134862
Conversation
# Conflicts: # Lib/asyncio/tools.py
|
(Skipping news because this is an easter egg) |
Sorry, something went wrong.
|
@ZeroIntensity Hmm... But isn't the CSV format legit, so in my (very bad) opinion it still need news? |
Sorry, something went wrong.
|
Oh, hm. I guess we could add an entry for only CSV. I'll leave the decision to @dpdani. |
Sorry, something went wrong.
Yes, please add news for CSV format |
Sorry, something went wrong.
johnzhou721
left a comment
There was a problem hiding this comment.
Yep, agreed with the NEWS part. But might it make the Easter Egg too obvious? Since people can just look at the PR through news. I think we might be able to split up the PRs into CSV and BSV and skip news on the latter, but it might be too much work.
Sorry, something went wrong.
We're not trying to hide or obsfucate; just not to advertise. |
Sorry, something went wrong.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sorry, something went wrong.
|
Sure, resolve.
|
Sorry, something went wrong.
I think there's not much point duplicating the issue now, but splitting into two PRs can make sense. @picnixz if you really think it's best, I can do the split. |
Sorry, something went wrong.
|
Yeah no need for two issues, but I would really like two separate PRs. For people reading commits, it's easier to spot the easter egg and it also makes reverting easier (if needed). It also allows us to make a funnier commit message. However, if @1st1 or any other codeowner is ok with adding the easter egg in this PR, I won't oppose their decision. EDIT: I pinged the wrong code owner |
Sorry, something went wrong.
|
I'll split the PR now |
Sorry, something went wrong.
|
Split done. The CSV format is here and the news entry is already ok. |
Sorry, something went wrong.
|
As far as I can tell there are no existing tests for this, #133284 has some for |
Sorry, something went wrong.
|
Yeah, I saw it didn't have tests before and didn't think it would be necessary to add them here. What do you think? |
Sorry, something went wrong.
|
Ah ok, you enabled auto-merge, I guess it's ok 👍 Thank you! |
Sorry, something went wrong.
470cbe9
into
python:main
Aug 6, 2025
…ython#134862) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
… ps`` (python#134862)" This reverts commit 470cbe9.
asyncio ps#134861