◐ Shell
reader mode source ↗
Skip to content

gh-135166: fix exception type capture in test.test_zstd#135167

Merged
zooba merged 1 commit into
python:mainfrom
hongweipeng:fix-test-zstd-error-type
Jun 5, 2025
Merged

gh-135166: fix exception type capture in test.test_zstd#135167
zooba merged 1 commit into
python:mainfrom
hongweipeng:fix-test-zstd-error-type

Conversation

@hongweipeng

@hongweipeng hongweipeng commented Jun 5, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Jun 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 5, 2025
Closed
@ZeroIntensity ZeroIntensity requested a review from emmatyping June 5, 2025 09:18
@vstinner

vstinner commented Jun 5, 2025

Copy link
Copy Markdown
Member

cc @emmatyping

emmatyping
emmatyping approved these changes Jun 5, 2025
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for the fix!

@emmatyping

emmatyping commented Jun 5, 2025

Copy link
Copy Markdown
Member

Looks like the error was changed in #133921

Hide details View details @zooba zooba merged commit 1b55e12 into python:main Jun 5, 2025
48 checks passed
@zooba zooba added the needs backport to 3.14 bugs and security fixes label Jun 5, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 5, 2025

Copy link
Copy Markdown

Thanks @hongweipeng for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 5, 2025
@hongweipeng @miss-islington
pythongh-135166: Fix exception type expected by test.test_zstd (pytho… …
b45bb8d 
…nGH-135167)

(cherry picked from commit 1b55e12)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@bedevere-app

bedevere-app Bot commented Jun 5, 2025

Copy link
Copy Markdown

GH-135189 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 5, 2025
@zooba

zooba commented Jun 5, 2025

Copy link
Copy Markdown
Member

Thanks for saving me the trouble of diagnosing this myself! I assume it needs to be in 3.14 too?

zooba pushed a commit that referenced this pull request Jun 5, 2025
@miss-islington @hongweipeng
[3.14] gh-135166: Fix exception type expected by test.test_zstd (GH-1… …
945af60 
…35167)

gh-135166: Fix exception type expected by test.test_zstd (GH-135167)
(cherry picked from commit 1b55e12)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hongweipeng @Pranjal095
pythongh-135166: Fix exception type expected by test.test_zstd (pytho… …
ef6d4df 
…nGH-135167)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hongweipeng @taegyunkim
pythongh-135166: Fix exception type expected by test.test_zstd (pytho… …
4c5c724 
…nGH-135167)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hongweipeng @Agent-Hellboy
pythongh-135166: Fix exception type expected by test.test_zstd (pytho… …
871b898 
…nGH-135167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmatyping emmatyping emmatyping approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hongweipeng @vstinner @emmatyping @zooba @ZeroIntensity