{{ message }}
bpo-36829: Document test.support.catch_unraisable_exception()#13554
Merged
vstinner merged 1 commit intoMay 24, 2019
Merged
Conversation
Member
Sorry, something went wrong.
Member
Author
Sorry, something went wrong.
graingert
reviewed
May 24, 2019
Member
Author
|
Oh. "del self.unraisable" was a good idea. I only used the context manager in a few places, but I already get it wrong in test_io :-) It's now fixed by this PR! |
Sorry, something went wrong.
tirkarthi
reviewed
May 24, 2019
graingert
reviewed
May 24, 2019
catch_unraisable_exception() now also removes its 'unraisable' attribute at the context manager exit.
Member
Author
|
@tirkarthi @graingert: Would you mind to review the updated PR? |
Sorry, something went wrong.
graingert
approved these changes
May 24, 2019
Member
Author
|
@graingert: Thanks for your very good feedback, it's very valuable! |
Sorry, something went wrong.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…GH-13554) catch_unraisable_exception() now also removes its 'unraisable' attribute at the context manager exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
catch_unraisable_exception() now also removes its 'unraisable'
attribute at the context manager exit.
https://bugs.python.org/issue36829