◐ Shell
reader mode source ↗
Skip to content

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [streams]#13671

Merged
miss-islington merged 3 commits into
python:masterfrom
eamanu:bpo-36373-streams
Jun 5, 2019
Merged

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [streams]#13671
miss-islington merged 3 commits into
python:masterfrom
eamanu:bpo-36373-streams

Conversation

@eamanu

@eamanu eamanu commented May 30, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Second step: streams.py

https://bugs.python.org/issue36373

@eamanu
bpo-36373: Deprecate explicit loop parameter …
ab1cdda 
This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Second step: streams.py
@eamanu eamanu requested review from 1st1 and asvetlov as code owners May 30, 2019 01:43
asvetlov
asvetlov requested changes May 30, 2019
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please remove all deprecations in public API but add these warnings to open_connection(), start_server(), open_unix_connection(), start_unix_server() instead.

@bedevere-bot

bedevere-bot commented May 30, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@eamanu

eamanu commented May 31, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented May 31, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@eamanu

eamanu commented May 31, 2019

Copy link
Copy Markdown
Contributor Author

@asvetlov the News Could be skipped?

asvetlov
asvetlov requested changes May 31, 2019
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please run your PR by ./python -Weeror -m test -v test_asyncio.
I suspect that some tests will fail (but didn't check it myself).
These tests should be wrapped by with self.assertWarns(DeprecationWarning): ... construction

@bedevere-bot

bedevere-bot commented May 31, 2019

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

asvetlov
asvetlov requested changes May 31, 2019
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

please drop the check here

@eamanu

eamanu commented Jun 5, 2019

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-bot

bedevere-bot commented Jun 5, 2019

Copy link
Copy Markdown

Thanks for making the requested changes!

@asvetlov: please review the changes made to this pull request.

@eamanu eamanu changed the title bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs Jun 5, 2019
@eamanu

eamanu commented Jun 5, 2019

Copy link
Copy Markdown
Contributor Author

@asvetlov I run the ./python -Weeror -m test -v test_asyncio and the test are ok

Ran 2145 tests in 80.981s

OK (skipped=35)
test_asyncio passed in 1 min 21 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 min 21 sec
Tests result: SUCCESS

15 hidden items Load more…
@miss-islington miss-islington merged commit 6d64a8f into python:master Jun 5, 2019
@miss-islington

miss-islington commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington

miss-islington commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 5, 2019

Copy link
Copy Markdown

GH-13833 is a backport of this pull request to the 3.8 branch.

@asvetlov

asvetlov commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Thank you @eamanu
Last days I was busy by firefighting with bugs to make 3.8 beta released.

The next big target is asyncio documentation cleanup (plus I need to land multithreaded support back again).

@asvetlov

asvetlov commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

@eamanu would you take a look on asyncio/locks.py and asyncio/queues.py?

miss-islington added a commit that referenced this pull request Jun 5, 2019
@miss-islington @eamanu
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP… …
8899b11 
…Is [streams] (GH-13671)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Second step: streams.py

https://bugs.python.org/issue36373
(cherry picked from commit 6d64a8f)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
@eamanu

eamanu commented Jun 5, 2019

Copy link
Copy Markdown
Contributor Author

@eamanu would you take a look on asyncio/locks.py and asyncio/queues.py?

@asvetlov Yes yes, I will start work on that today. I was busy the last weekend. And I have pending #13670

@eamanu eamanu deleted the bpo-36373-streams branch June 5, 2019 11:08
@asvetlov

asvetlov commented Jun 5, 2019

Copy link
Copy Markdown
Contributor

Thank you. No rush, we have enough time during betas

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@eamanu @DinoV
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP… …
8f30766 
…Is [streams] (pythonGH-13671)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Second step: streams.py





https://bugs.python.org/issue36373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

+1 more reviewer

@Carreau Carreau Carreau left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eamanu @bedevere-bot @miss-islington @asvetlov @Carreau @the-knights-who-say-ni