{{ message }}
gh-136728: Refactor build.yml CI config and multissltests.py#136729
Closed
WillChilds-Klein wants to merge 222 commits into
Closed
gh-136728: Refactor build.yml CI config and multissltests.py#136729WillChilds-Klein wants to merge 222 commits into
WillChilds-Klein wants to merge 222 commits into
Conversation
Suggested by @hugovk [1]. [1]: hugovk@a3f2ba9
picnixz
reviewed
Aug 2, 2025
picnixz
left a comment
Member
There was a problem hiding this comment.
If possible, I want multissltests to be refactored separately.
Sorry, something went wrong.
1 hidden conversation
Load more…
hugovk
reviewed
Aug 5, 2025
AA-Turner
reviewed
Aug 5, 2025
AA-Turner
reviewed
Aug 5, 2025
AA-Turner
reviewed
Aug 5, 2025
AA-Turner
reviewed
Aug 5, 2025
AA-Turner
reviewed
Aug 5, 2025
Contributor
Author
|
Hi folks, sorry for my delayed responses. Hoping to incorporate feedback here later this week or next. |
Sorry, something went wrong.
298 hidden items
Load more…
Sorry, something went wrong.
Member
|
Oh yuck, sorry for the pings, this knotty merge resolution pulled in a lot of code... I'll apply some of the suggestions to the branch, then close the PR and open a new one. |
Sorry, something went wrong.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Notes
Please see #136728. Changes to
build.ymlare directly adapted from @hugovk's proof-of-concept here.Testing