GH-135904: Add tests for the JIT build process#136766
Conversation
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 867a686 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136766%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
|
!buildbot aarch64 RHEL8 LTO |
Sorry, something went wrong.
|
🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 7c9c3ff 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136766%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sorry, something went wrong.
diegorusso
left a comment
There was a problem hiding this comment.
This is not fully related to this PR but sometime I change this line https://github.com/python/cpython/pull/136766/files#diff-700c6057d24addce74e8787edb5f5556f718299f6ef1742cbb1d79580cdb535cR199 and add delete=False because I want to inspect the temporary files that have been generated.
Do you think that we should expose this to the user (it would be useful for me)?
Sorry, something went wrong.
It's not a hard push back, but shouldn't be these changes go to a separate PR? |
Sorry, something went wrong.
There was a problem hiding this comment.
Ah, just noticed this was still open and I don't see any reason why it wouldn't still be valuable! I think the main thing outstanding was Diego's comment (#136766 (comment)). Otherwise, I'd be happy with an additional comment about the --input-file being used for tests and merging main back in. @brandtbucher I know you're busy these days; do you need/want help carrying this over the line?
Sorry, something went wrong.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
This is overdue, but it's especially valuable now that we're doing more subtle transformations on the machine code at JIT build time. This has a number of benefits:
musttaildoesn't optimize sibling calls llvm/llvm-project#147813The new test is in
Lib/test/test_jit_stencils.py. This test usesTools/jit/test/test_executor_cases.c.hto generate a few small test stencils, and compares them to the expected output in the correspondingTools/jit/test/test_jit_stencils-*.hfile.Most of the changes in
Tools/jit/_targets.pyare just cleanup to make the generated stencils simpler and more consistent, or to fix the writable-data bug I mentioned above.