◐ Shell
reader mode source ↗
Skip to content

gh-124111: test macOS CI with Tk 9#136959

Closed
ned-deily wants to merge 1 commit into
python:mainfrom
ned-deily:gh-124111-macos-ci-tk9
Closed

gh-124111: test macOS CI with Tk 9#136959
ned-deily wants to merge 1 commit into
python:mainfrom
ned-deily:gh-124111-macos-ci-tk9

Conversation

@ned-deily

@ned-deily ned-deily commented Jul 22, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jul 22, 2025
Open
@ezio-melotti ezio-melotti mentioned this pull request Jul 22, 2025
Merged
@itamaro

itamaro commented Aug 3, 2025

Copy link
Copy Markdown
Contributor

@ned-deily should this be a draft PR?

@ned-deily

ned-deily commented Aug 5, 2025

Copy link
Copy Markdown
Member Author

should this be a draft PR?

Sure, I guess. This PR was meant to just confirm that the macOS CI jobs using Tk 9.0 instead of Tk 8.6 have test failures that need to be resolved before we can move to 9.0. We need someone to work on them as discussed in the issue.

@ned-deily ned-deily marked this pull request as draft August 5, 2025 03:54
@hugovk hugovk mentioned this pull request Aug 5, 2025
Merged
@hugovk

hugovk commented Aug 5, 2025

Copy link
Copy Markdown
Member

I've included this PR and added tests in #137424. (I would have pushed here, but GitHub said this branch is protected.)

@ned-deily

ned-deily commented Aug 5, 2025

Copy link
Copy Markdown
Member Author

I've included this PR and added tests in #137424. (I would have pushed here, but GitHub said this branch is protected.)

Thanks for the tests. I'm not sure why you couldn't push to this PR but it may have been due to today's reported Github problems earlier. Closing in favor of #137424.

@ned-deily ned-deily closed this Aug 5, 2025
@ned-deily ned-deily deleted the gh-124111-macos-ci-tk9 branch August 6, 2025 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner

@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Assignees

No one assigned

Labels

DO-NOT-MERGE OS-mac skip news topic-tkinter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ned-deily @itamaro @hugovk