◐ Shell
reader mode source ↗
Skip to content

gh-89687: fix get_type_hints with dataclasses __init__ generation#137168

Open
Tishka17 wants to merge 2 commits into
python:mainfrom
Tishka17:issue-45524
Open

gh-89687: fix get_type_hints with dataclasses __init__ generation#137168
Tishka17 wants to merge 2 commits into
python:mainfrom
Tishka17:issue-45524

Conversation

@Tishka17

@Tishka17 Tishka17 commented Jul 28, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown

@Tishka17 Tishka17 requested a review from ericvsmith as a code owner July 28, 2025 14:18
@python-cla-bot

python-cla-bot Bot commented Jul 28, 2025 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Jul 28, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request Jul 28, 2025
Open
@Tishka17

Tishka17 commented Jul 28, 2025

Copy link
Copy Markdown
Author

As I see at this point:

  1. annotationlib.get_annotations does not resolve ForwardRef at all
  2. typing.get_type_hints ignores module in ForwardRef

@Tishka17 Tishka17 requested a review from JelleZijlstra as a code owner July 28, 2025 15:58
@github-actions

github-actions Bot commented Apr 27, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tishka17 @JelleZijlstra