◐ Shell
reader mode source ↗
Skip to content

bpo-17576: Strict __int__ and __index__ return types; operator.index always uses __index__#13740

Closed
mdickinson wants to merge 2 commits into
python:masterfrom
mdickinson:make-int-and-index-return-types-strict
Closed

bpo-17576: Strict __int__ and __index__ return types; operator.index always uses __index__#13740
mdickinson wants to merge 2 commits into
python:masterfrom
mdickinson:make-int-and-index-return-types-strict

Conversation

@mdickinson

@mdickinson mdickinson commented Jun 2, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This PR:

  • turns the DeprecationWarnings introduced by @serhiy-storchaka in Python 3.4 for non-integer return values from __int__ and __index__ into TypeErrors
  • makes operator.index and PyNumber_Index always give the same return value as __index__. This fixes the inconsistency reported by @warsaw in bpo-17576.

Still working on doc updates and what's-new entries, but making the PR now so that others can review.

https://bugs.python.org/issue17576

@mdickinson

mdickinson commented Jun 2, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

This PR should also allow simplifications to many parts of the codebase that currently need to check what type they got back from a PyNumber_Index call.

@mdickinson mdickinson added type-feature A feature request or enhancement type-bug An unexpected behavior, bug, or error labels Jun 2, 2019
@mdickinson

mdickinson commented Jun 2, 2019

Copy link
Copy Markdown
Member Author

The test failure appears to be due to test_asyncio altering the test environment. It seems unlikely that it's related to the changes in this PR (but anything's possible).

@serhiy-storchaka

serhiy-storchaka commented Jun 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Some of these warnings were added in 3.8. We cannot turn them into TypeError in the same version.

@tirkarthi

tirkarthi commented Jun 3, 2019

Copy link
Copy Markdown
Member

The test failure appears to be due to test_asyncio altering the test environment. It seems unlikely that it's related to the changes in this PR (but anything's possible).

Could you please try rebasing on master to see if it helps. One of the assertion errors in test_asyncio was fixed with #13754 .

@mdickinson

mdickinson commented Jun 3, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

Some of these warnings were added in 3.8.

Are you sure? Which ones? The PR removes 3 DeprecationWarning blocks: one in abstract.c and two in longobject.c, and it looks to me as though all three were introduced in 31a6554

@serhiy-storchaka

serhiy-storchaka commented Jun 3, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The warning added in bpo-36048.

@mdickinson

mdickinson commented Jun 3, 2019

Copy link
Copy Markdown
Member Author

The warning added in bpo-36048.

Ah yes, right.

Good point. Closing.

@mdickinson mdickinson closed this Jun 3, 2019
@mdickinson mdickinson deleted the make-int-and-index-return-types-strict branch June 3, 2019 10:33
@warsaw warsaw mentioned this pull request Jan 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

awaiting core review type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mdickinson @serhiy-storchaka @tirkarthi @the-knights-who-say-ni @bedevere-bot