◐ Shell
reader mode source ↗
Skip to content

gh-137400: Fix thread-safety issues when profiling all threads#137518

Merged
colesbury merged 10 commits into
python:mainfrom
colesbury:gh-137400-now-with-fewer-crashes
Aug 13, 2025
Merged

gh-137400: Fix thread-safety issues when profiling all threads#137518
colesbury merged 10 commits into
python:mainfrom
colesbury:gh-137400-now-with-fewer-crashes

Conversation

@colesbury

@colesbury colesbury commented Aug 7, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

There were a few thread-safety issues when profiling or tracing all threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

  • The loop over thread states could crash if a thread exits concurrently (in both the free threading and default build)
  • The modification of c_profilefunc and c_tracefunc wasn't thread-safe on the free threading build.

@colesbury
pythongh-137400: Fix a thread-safety issues when profiling all threads …
bcb2772 
There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

* The loop over thread states could crash if a thread exits concurrently
  (in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
  thread-safe on the free threading build.
@bedevere-app bedevere-app Bot mentioned this pull request Aug 7, 2025
Closed
@colesbury colesbury added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 7, 2025
@bedevere-bot

bedevere-bot commented Aug 7, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 09b28c8 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137518%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@colesbury colesbury changed the title gh-137400: Fix a thread-safety issues when profiling all threads Aug 7, 2025
@colesbury colesbury mentioned this pull request Aug 7, 2025
Merged
@colesbury colesbury added needs backport to 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Aug 7, 2025
@colesbury colesbury marked this pull request as ready for review August 7, 2025 16:15
ZeroIntensity
ZeroIntensity reviewed Aug 8, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

A few minor comments

7 hidden items Load more…
@colesbury @kumaraditya303
Update Python/legacy_tracing.c …
9225c9a 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Hide details View details @colesbury colesbury merged commit a10152f into python:main Aug 13, 2025
62 checks passed
@colesbury colesbury deleted the gh-137400-now-with-fewer-crashes branch August 13, 2025 18:15
@miss-islington-app

miss-islington-app Bot commented Aug 13, 2025

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Aug 13, 2025

Copy link
Copy Markdown

Sorry, @colesbury, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a10152f8fd0f4b291e53d646cffe22fbeec73e1e 3.14

@miss-islington-app

miss-islington-app Bot commented Aug 13, 2025

Copy link
Copy Markdown

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a10152f8fd0f4b291e53d646cffe22fbeec73e1e 3.13

colesbury added a commit to colesbury/cpython that referenced this pull request Aug 13, 2025
@colesbury
[3.14] pythongh-137400: Fix thread-safety issues when profiling all t… …
a4b3a4b 
…hreads (pythongh-137518)

There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

* The loop over thread states could crash if a thread exits concurrently
  (in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
  thread-safe on the free threading build.
(cherry picked from commit a10152f)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

bedevere-app Bot commented Aug 13, 2025

Copy link
Copy Markdown

GH-137730 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 13, 2025
colesbury added a commit to colesbury/cpython that referenced this pull request Aug 13, 2025
@colesbury
[3.13] pythongh-137400: Fix thread-safety issues when profiling all t… …
4c8fa53 
…hreads (pythongh-137518)

There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

* The loop over thread states could crash if a thread exits concurrently
  (in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
  thread-safe on the free threading build.
(cherry picked from commit a10152f)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app

bedevere-app Bot commented Aug 13, 2025

Copy link
Copy Markdown

GH-137733 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Aug 13, 2025
@kumaraditya303 kumaraditya303 mentioned this pull request Aug 26, 2025
Closed
colesbury added a commit that referenced this pull request Oct 7, 2025
@colesbury @encukou
[3.14] gh-137400: Fix thread-safety issues when profiling all threads (… …
fb699ef 
…gh-137518) (gh-137730)

There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

* The loop over thread states could crash if a thread exits concurrently
  (in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
  thread-safe on the free threading build.
(cherry picked from commit a10152f)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
colesbury added a commit that referenced this pull request Oct 9, 2025
@colesbury
[3.13] gh-137400: Fix thread-safety issues when profiling all threads (… …
16d2e97 
…gh-137518) (gh-137733)

There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

* The loop over thread states could crash if a thread exits concurrently
  (in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
  thread-safe on the free threading build.
(cherry picked from commit a10152f)
@devdanzin devdanzin mentioned this pull request Nov 17, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian gaogaotiantian left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@colesbury @bedevere-bot @gaogaotiantian @ZeroIntensity @kumaraditya303