{{ message }}
GH-137426: Remove code deprecation of importlib.abc.ResourceLoader#137567
Merged
brettcannon merged 3 commits intoAug 11, 2025
Merged
GH-137426: Remove code deprecation of importlib.abc.ResourceLoader#137567brettcannon merged 3 commits into
importlib.abc.ResourceLoader#137567brettcannon merged 3 commits into
Conversation
Member
Sorry, something went wrong.
…ader` Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility.
Member
Author
Sorry, something went wrong.
ncoghlan
approved these changes
Aug 11, 2025
ncoghlan
left a comment
ncoghlan
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
encukou
approved these changes
Aug 11, 2025
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
This looks like the correct direction to me!
Sorry, something went wrong.
hugovk
approved these changes
Aug 11, 2025
…W-Rk2.rst Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Hide details
View details
brettcannon
merged commit
brettcannon
merged commit 7140b99
into
python:main
Aug 11, 2025
42 checks passed
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 11, 2025
…ader` (pythonGH-137567) Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility. --------- (cherry picked from commit 7140b99) Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
added a commit
that referenced
this pull request
Aug 12, 2025
maurycy
added a commit
to maurycy/cpython
that referenced
this pull request
Aug 12, 2025
* main: pythongh-137288: Update 3.14 magic numbers (pythonGH-137665) pythongh-135228: When @DataClass(slots=True) replaces a dataclass, make the original class collectible (take 2) (pythonGH-137047) pythongh-126008: Improve docstrings for Tkinter cget and configure methods (pythonGH-133303) pythongh-131885: Use positional-only markers for ``max()`` and ``min()`` (python#131868) pythonGH-137426: Remove code deprecation of `importlib.abc.ResourceLoader` (pythonGH-137567) pythongh-125897: Mark range function parameters as positional only (python#125945) pythongh-137400: Fix a crash when disabling profiling across all threads (pythongh-137471) pythongh-115766: Fix IPv4Interface.is_unspecified (pythonGH-137326) pythongh-128813: cleanup C-API docs for PyComplexObject (pythonGH-137579) pythongh-135953: Profile a module or script with sampling profiler (python#136777) Fix documentation of hash in PyHash_FuncDef (python#137595)
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…ader` (pythonGH-137567) Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility. --------- Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…ourceLoader` (pythonGH-137567) (python#137654) Co-authored-by: Brett Cannon <brett@python.org> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Enough other classes in
importlib.abcinherit from the class and the deprecation was to redirect people toTraversableResources. The documentation now makes it clear the class only exists for backwards compatibility.importlib.abc.SourceLoaderissuesDeprecationWarningbecause it inherits fromResourceLoader#137426📚 Documentation preview 📚: https://cpython-previews--137567.org.readthedocs.build/