◐ Shell
reader mode source ↗
Skip to content

GH-137573: Check C stack depth before stack allocating JIT optimizer struct#137676

Closed
markshannon wants to merge 4 commits into
python:mainfrom
faster-cpython:check-stack-in-jit
Closed

GH-137573: Check C stack depth before stack allocating JIT optimizer struct#137676
markshannon wants to merge 4 commits into
python:mainfrom
faster-cpython:check-stack-in-jit

Conversation

@markshannon

@markshannon markshannon commented Aug 12, 2025

Copy link
Copy Markdown
Member

@Fidget-Spinner

Copy link
Copy Markdown
Member

Just so I'm clear: you plan to move this to the thread state later but only on main right? So that we don't change the struct layout in an rc for 3.14?

markshannon and others added 2 commits August 13, 2025 11:44
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@Fidget-Spinner

Copy link
Copy Markdown
Member

Can you please add a Py_NO_INLINE to the _PyOptimizer_Optimize function too? I don't think this will fix it as if it's inlined, the alloca might be hoisted out to the main interpreter loop by the compiler.

@markshannon

Copy link
Copy Markdown
Member Author

Can you please add a Py_NO_INLINE to the _PyOptimizer_Optimize function too? I don't think this will fix it as if it's inlined, the alloca might be hoisted out to the main interpreter loop by the compiler.

Yes, but not in this PR as it seems unrelated

@markshannon

Copy link
Copy Markdown
Member Author

Just so I'm clear: you plan to move this to the thread state later but only on main right? So that we don't change the struct layout in an rc for 3.14?

Yes, that's the plan.

@markshannon markshannon added the needs backport to 3.14 bugs and security fixes label Aug 13, 2025
@markshannon

Copy link
Copy Markdown
Member Author

We've already started moving the buffers to the heap, so this won't be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants