◐ Shell
reader mode source ↗
Skip to content

[3.13] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518)#137733

Merged
colesbury merged 6 commits into
python:3.13from
colesbury:backport-a10152f-3.13
Oct 9, 2025
Merged

[3.13] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518)#137733
colesbury merged 6 commits into
python:3.13from
colesbury:backport-a10152f-3.13

Conversation

@colesbury

@colesbury colesbury commented Aug 13, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

There were a few thread-safety issues when profiling or tracing all threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

  • The loop over thread states could crash if a thread exits concurrently (in both the free threading and default build)
  • The modification of c_profilefunc and c_tracefunc wasn't thread-safe on the free threading build. (cherry picked from commit a10152f)

@colesbury
[3.13] pythongh-137400: Fix thread-safety issues when profiling all t… …
4c8fa53 
…hreads (pythongh-137518)

There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

* The loop over thread states could crash if a thread exits concurrently
  (in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
  thread-safe on the free threading build.
(cherry picked from commit a10152f)

Co-authored-by: Sam Gross <colesbury@gmail.com>
This was referenced Aug 13, 2025
Closed
Merged
@Yhg1s

Yhg1s commented Aug 14, 2025

Copy link
Copy Markdown
Member

FYI, the ABI change seems fine to me.

@colesbury colesbury marked this pull request as ready for review September 15, 2025 12:08
encukou
encukou approved these changes Oct 8, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

The backport looks good to me!

Though, given that 3.13t is experimental and 3.14 is now out, maybe we should start thinking about not doing backports like this any more...

@colesbury

colesbury commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

Though, given that 3.13t is experimental and 3.14 is now out, maybe we should start thinking about not doing backports like this any more...

I generally agree, but one of the reasons I decided to backport this is that I think it will make the free-threaded CI more stable as well as fixing a thread-safety issue.

Hide details View details @colesbury colesbury merged commit 16d2e97 into python:3.13 Oct 9, 2025
81 of 83 checks passed
@colesbury colesbury deleted the backport-a10152f-3.13 branch October 9, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments

@encukou encukou encukou approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@colesbury @Yhg1s @encukou @markshannon