◐ Shell
reader mode source ↗
Skip to content

Revert "bpo-36818: Add PyInterpreterState.runtime field. (gh-13129)"#13795

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:revert_interp_runtime
Jun 4, 2019
Merged

Revert "bpo-36818: Add PyInterpreterState.runtime field. (gh-13129)"#13795
vstinner merged 1 commit into
python:masterfrom
vstinner:revert_interp_runtime

Conversation

@vstinner

@vstinner vstinner commented Jun 4, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@vstinner

vstinner commented Jun 4, 2019

Copy link
Copy Markdown
Member Author

I tested manually that this PR fix https://bugs.python.org/issue37135

pablogsal
pablogsal approved these changes Jun 4, 2019
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Checked locally:

396e0a8 -> ./python stress.py crashes
396e0a8^ -> ./python stress.py does not crash

@vstinner vstinner merged commit 0fd2c30 into python:master Jun 4, 2019
@vstinner vstinner deleted the revert_interp_runtime branch June 4, 2019 01:15
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
Revert "bpo-36818: Add PyInterpreterState.runtime field. (pythongh-13129 …
72ba7cf 
)" (pythonGH-13795)

This reverts commit 396e0a8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @pablogsal @the-knights-who-say-ni @bedevere-bot