◐ Shell
reader mode source ↗
Skip to content

bpo-19903: IDLE: Change to inspect.signature for calltips#1382

Closed
louisom wants to merge 10 commits into
python:masterfrom
louisom:bpo-19903
Closed

bpo-19903: IDLE: Change to inspect.signature for calltips#1382
louisom wants to merge 10 commits into
python:masterfrom
louisom:bpo-19903

Conversation

@louisom

@louisom louisom commented May 2, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This commit change the get_argspec from using inspect.getfullargspec
to inspect.signature. It will improve the tip message for use.

@louisom
bpo-19903: Change to inspect.signature for calltips …
8c8d6aa 
This commit change the get_argspec from using inspect.getfullargspec
to inspect.signature. It will improve the tip message for use.

Also, if object is not callable, now will return this message for
user, not blank tips. If the methods has an invalid method signature,
it will also return message to user.
@mention-bot

mention-bot commented May 2, 2017

Copy link
Copy Markdown

@lulouie, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @serhiy-storchaka to be potential reviewers.

@brettcannon brettcannon added the type-feature A feature request or enhancement label May 2, 2017
@terryjreedy terryjreedy self-assigned this May 2, 2017
@louisom

louisom commented May 3, 2017

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka @terryjreedy Also add the test for first param not self test.

@terryjreedy terryjreedy self-requested a review May 4, 2017 07:07
terryjreedy
terryjreedy requested changes May 4, 2017
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

See msg292964 on issue for explanations and comment on what test addition is needed.

@louisom louisom changed the title bpo-19903: Change to inspect.signature for calltips May 10, 2017
@mlouielu mlouielu mentioned this pull request Jul 23, 2017
Merged
@terryjreedy

terryjreedy commented Jul 24, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Replaced by #2822 with new account name. LEAVE THIS OPEN FOR NOW. Since it will not be merged, I am using it as one example of not being able to edit the code due to lack permission.

@terryjreedy

terryjreedy commented Aug 2, 2017

Copy link
Copy Markdown
Member

Edit by others being turned off seems to be resolved for now.

@terryjreedy terryjreedy closed this Aug 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@terryjreedy terryjreedy terryjreedy requested changes

Assignees

@terryjreedy terryjreedy

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@louisom @mention-bot @terryjreedy @serhiy-storchaka @brettcannon @the-knights-who-say-ni