◐ Shell
reader mode source ↗
Skip to content

gh-78502: Add a trackfd parameter to mmap.mmap() on Windows#138238

Merged
serhiy-storchaka merged 7 commits into
python:mainfrom
serhiy-storchaka:mmap-trackfd-win
Sep 3, 2025
Merged

gh-78502: Add a trackfd parameter to mmap.mmap() on Windows#138238
serhiy-storchaka merged 7 commits into
python:mainfrom
serhiy-storchaka:mmap-trackfd-win

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 29, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

If trackfd is False, the file handle corresponding to fileno will not be duplicated.

📚 Documentation preview 📚: https://cpython-previews--138238.org.readthedocs.build/

@serhiy-storchaka
pythongh-78502: AAdd a trackfd parameter to mmap.mmap() on Windows …
d1ce256 
If trackfd is False, the file handle corresponding to fileno
will not be duplicated.
@bedevere-app bedevere-app Bot mentioned this pull request Aug 29, 2025
Closed
@serhiy-storchaka
pythongh-78502: AAdd a trackfd parameter to mmap.mmap() on Windows …
558beef 
If trackfd is False, the file handle corresponding to fileno
will not be duplicated.
@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 29, 2025
@bedevere-bot

bedevere-bot commented Aug 29, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 558beef 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138238%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Aug 29, 2025
@serhiy-storchaka serhiy-storchaka changed the title gh-78502: AAdd a trackfd parameter to mmap.mmap() on Windows Aug 29, 2025
encukou
encukou approved these changes Sep 1, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I'm not much of a Windows expert, but, the code looks good to me! Thank you!

zooba
zooba reviewed Sep 1, 2025
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Other than that condition, looks fine to me.

vstinner
vstinner approved these changes Sep 2, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

serhiy-storchaka and others added 2 commits September 2, 2025 18:43
@serhiy-storchaka

serhiy-storchaka commented Sep 2, 2025

Copy link
Copy Markdown
Member Author

Before merging this PR, it would be convenient to merge #24781.

@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 2, 2025
Closed
Hide details View details @serhiy-storchaka serhiy-storchaka merged commit 7274d07 into python:main Sep 3, 2025
45 checks passed
@serhiy-storchaka serhiy-storchaka deleted the mmap-trackfd-win branch September 3, 2025 08:31
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@serhiy-storchaka @lkollar
pythongh-78502: Add a trackfd parameter to mmap.mmap() on Windows (py… …
1a3e61d 
…thonGH-138238)

If trackfd is False, the file handle corresponding to fileno
will not be duplicated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

@vstinner vstinner vstinner approved these changes

@encukou encukou encukou approved these changes

@AA-Turner AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @bedevere-bot @vstinner @encukou @zooba