◐ Shell
reader mode source ↗
Skip to content

GH-101100: Resolve reference warnings in library/stdtypes.rst#138420

Merged
AA-Turner merged 3 commits into
python:mainfrom
AA-Turner:docs/refwarn/stdtypes
Nov 22, 2025
Merged

GH-101100: Resolve reference warnings in library/stdtypes.rst#138420
AA-Turner merged 3 commits into
python:mainfrom
AA-Turner:docs/refwarn/stdtypes

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 3, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@AA-Turner AA-Turner requested a review from hugovk as a code owner September 3, 2025 00:26
@AA-Turner AA-Turner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 3, 2025
@bedevere-app bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Sep 3, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Sep 3, 2025
@AA-Turner AA-Turner changed the title Resolve reference warnings in library/stdtypes.rst Sep 3, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 3, 2025
Open
@serhiy-storchaka

serhiy-storchaka commented Sep 3, 2025

Copy link
Copy Markdown
Member

I think that the right fix for this is to add anchors instead of removing references.

@AA-Turner

AA-Turner commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

@serhiy-storchaka I've generally been hesitant to suppress cross-references, but I think all the instances here make sense, given their context. Are there some specific ones you would revert?

A

@serhiy-storchaka

serhiy-storchaka commented Sep 3, 2025

Copy link
Copy Markdown
Member

Are there some specific ones you would revert?

All of them? See my suggestion #101100 (comment) . After implementing it the references in footnotes will gone, as they will become the part of the method description, and many other references will became working. After that we can check what remains.

@AA-Turner

AA-Turner commented Sep 3, 2025

Copy link
Copy Markdown
Member Author

See #138474, putting this in draft for now.

A

@AA-Turner AA-Turner marked this pull request as draft September 3, 2025 21:00
@AA-Turner
Merge branch 'main' into docs/refwarn/stdtypes …
b06ed6f 
# Conflicts:
#	Doc/library/stdtypes.rst
@AA-Turner AA-Turner marked this pull request as ready for review September 5, 2025 20:58
@hugovk

hugovk commented Nov 22, 2025

Copy link
Copy Markdown
Member

(Resolved conflict)

Hide details View details @AA-Turner AA-Turner merged commit cde19e5 into python:main Nov 22, 2025
28 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 22, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 22, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 22, 2025
@AA-Turner @miss-islington
pythonGH-101100: Resolve reference warnings in library/stdtypes.rst (p… …
f82a0a5 
…ythonGH-138420)

(cherry picked from commit cde19e5)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Nov 22, 2025

Copy link
Copy Markdown

GH-141855 is a backport of this pull request to the 3.14 branch.

@miss-islington-app

miss-islington-app Bot commented Nov 22, 2025

Copy link
Copy Markdown

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cde19e565cc9127fe5db38358ebf3bbd75a9d2cd 3.13

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 22, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@AA-Turner @StanFromIreland
[3.13] pythonGH-101100: Resolve reference warnings in library/stdtype… …
fa960d3 
…s.rst (pythonGH-138420)

(cherry picked from commit cde19e5)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@StanFromIreland

StanFromIreland commented Dec 6, 2025

Copy link
Copy Markdown
Member

We actually don't need to backport this, it is superseded by the backport of 1d8f3ed, #142345.

@StanFromIreland StanFromIreland removed the needs backport to 3.13 bugs and security fixes label Dec 6, 2025
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@AA-Turner @StanFromIreland
pythonGH-101100: Resolve reference warnings in library/stdtypes.rst (p… …
a65a6e0 
…ython#138420)
ashm-dev pushed a commit to ashm-dev/cpython that referenced this pull request Dec 8, 2025
@AA-Turner @ashm-dev
pythonGH-101100: Resolve reference warnings in library/stdtypes.rst (p… …
9739b12 
…ython#138420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@hugovk hugovk hugovk is a code owner

Assignees

@AA-Turner AA-Turner

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AA-Turner @serhiy-storchaka @hugovk @StanFromIreland @aisk