◐ Shell
reader mode source ↗
Skip to content

gh-90548: Skip NODEV portion of test_makedev when linked to musl#138593

Merged
zware merged 1 commit into
python:mainfrom
zware:musl_nodev_fix
Sep 6, 2025
Merged

gh-90548: Skip NODEV portion of test_makedev when linked to musl#138593
zware merged 1 commit into
python:mainfrom
zware:musl_nodev_fix

Conversation

@zware

@zware zware commented Sep 6, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@zware zware added tests Tests in the Lib/test dir skip news labels Sep 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 6, 2025
Closed
@zware

zware commented Sep 6, 2025

Copy link
Copy Markdown
Member Author

!buildbot Alpine

@bedevere-bot

bedevere-bot commented Sep 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zware for commit ea3a168 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138593%2Fmerge

The command will test the builders whose names match following regular expression: Alpine

The builders matched are:

  • AMD64 Alpine Linux PR

@zware zware marked this pull request as ready for review September 6, 2025 18:59
Hide details View details @zware zware merged commit bbe00d5 into python:main Sep 6, 2025
49 of 50 checks passed
@zware zware deleted the musl_nodev_fix branch September 6, 2025 19:01
zware added a commit to zware/cpython that referenced this pull request Sep 6, 2025
@zware
pythongh-90548: Skip NODEV portion of test_makedev when linked to musl ( …
63b5956 
pythonGH-138593)
@zware zware added the needs backport to 3.14 bugs and security fixes label Sep 6, 2025
@miss-islington-app

miss-islington-app Bot commented Sep 6, 2025

Copy link
Copy Markdown

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 6, 2025
@zware @miss-islington
pythongh-90548: Skip NODEV portion of test_makedev when linked to musl ( …
5ba8923 
pythonGH-138593)

(cherry picked from commit bbe00d5)

Co-authored-by: Zachary Ware <zach@python.org>
@bedevere-app

bedevere-app Bot commented Sep 6, 2025

Copy link
Copy Markdown

GH-138602 is a backport of this pull request to the 3.14 branch.

hugovk pushed a commit that referenced this pull request Sep 7, 2025
@miss-islington @zware
[3.14] gh-90548: Skip NODEV portion of test_makedev when linked to mu… …
194fe15 
…sl (GH-138593) (#138602)

Co-authored-by: Zachary Ware <zach@python.org>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @zware @kumaraditya303
[3.14] pythongh-90548: Skip NODEV portion of test_makedev when linked… …
aba8ae7 
… to musl (pythonGH-138593) (python#138602)

Co-authored-by: Zachary Ware <zach@python.org>
@zware zware mentioned this pull request Sep 9, 2025
Closed
@rossburton

rossburton commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Can this be backported to 3.13 too?

@miss-islington-app

miss-islington-app Bot commented Sep 9, 2025

Copy link
Copy Markdown

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@zware @miss-islington
pythongh-90548: Skip NODEV portion of test_makedev when linked to musl ( …
42b6e70 
pythonGH-138593)

(cherry picked from commit bbe00d5)

Co-authored-by: Zachary Ware <zach@python.org>
@bedevere-app

bedevere-app Bot commented Sep 9, 2025

Copy link
Copy Markdown

GH-138713 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 9, 2025
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@zware @lkollar
pythongh-90548: Skip NODEV portion of test_makedev when linked to musl ( …
b0267b3 
pythonGH-138593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zware @bedevere-bot @rossburton