◐ Shell
reader mode source ↗
Skip to content

gh-76007: Deprecate __version__ attribute#138675

Merged
hugovk merged 10 commits into
python:mainfrom
hugovk:3.15-deprecate__version__
Sep 29, 2025
Merged

gh-76007: Deprecate __version__ attribute#138675
hugovk merged 10 commits into
python:mainfrom
hugovk:3.15-deprecate__version__

Conversation

@hugovk

@hugovk hugovk commented Sep 8, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Sep 8, 2025
Closed
@sethmlarson

sethmlarson commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

Reviewed the SBOM changes.

merwok
merwok approved these changes Sep 9, 2025
View reviewed changes

@merwok merwok left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

thanks for this!

vsajip
vsajip approved these changes Sep 9, 2025
View reviewed changes

@vsajip vsajip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I'm fine with the logging-related changes, thank you.

@hugovk @aisk
Whitespace …
6e01534 
Co-authored-by: AN Long <aisk@users.noreply.github.com>
savannahostrowski
savannahostrowski approved these changes Sep 15, 2025
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM for argparse! Thanks Hugo!

hugovk
hugovk commented Sep 17, 2025
View reviewed changes
5 hidden conversations Load more…
vstinner
vstinner approved these changes Sep 18, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

Hide details View details @hugovk hugovk merged commit 872eafd into python:main Sep 29, 2025
45 checks passed
@hugovk hugovk deleted the 3.15-deprecate__version__ branch September 29, 2025 09:03
@bedevere-bot

bedevere-bot commented Sep 29, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows PGO NoGIL 3.x (tier-1) has failed when building commit 872eafd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1622/builds/2753) and take a look at the build logs.
  4. Check if the failure is related to this commit (872eafd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1622/builds/2753

Failed tests:

  • test_tracemalloc
  • test_zipfile

Failed subtests:

  • test_write_filtered_python_package - test.test_zipfile.test_core.PyZipFileTests.test_write_filtered_python_package

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\test\test_zipfile\test_core.py", line 1435, in test_write_filtered_python_package
    zipfp.writepy(packagedir)
    ~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\zipfile\__init__.py", line 2226, in writepy
    self.writepy(path, basename,
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^
                 filterfunc=filterfunc)  # Recursive call
                 ^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\zipfile\__init__.py", line 2233, in writepy
    fname, arcname = self._get_codename(path[0:-3],
                     ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
                                        basename)
                                        ^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\zipfile\__init__.py", line 2313, in _get_codename
    if _compile(file_py):
       ~~~~~~~~^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\zipfile\__init__.py", line 2276, in _compile
    py_compile.compile(file, doraise=True, optimize=optimize)
    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\py_compile.py", line 172, in compile
    importlib._bootstrap_external._write_atomic(cfile, bytecode, mode)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap_external>", line 217, in _write_atomic
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\Administrator\\buildarea\\3.x.itamaro-win64-srv-22-aws.nogil.pgo\\build\\Lib\\test\\test_ast\\__pycache__\\snippets.cpython-315.pyc.3206632993856' -> 'C:\\Users\\Administrator\\buildarea\\3.x.itamaro-win64-srv-22-aws.nogil.pgo\\build\\Lib\\test\\test_ast\\__pycache__\\snippets.cpython-315.pyc'

@bedevere-bot

bedevere-bot commented Sep 29, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows PGO NoGIL 3.x (tier-1) has failed when building commit 872eafd.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1622/builds/2755) and take a look at the build logs.
  4. Check if the failure is related to this commit (872eafd) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1622/builds/2755

Failed tests:

  • test_launcher

Failed subtests:

  • test_search_major_2 - test.test_launcher.TestLauncher.test_search_major_2
  • test_search_major_3 - test.test_launcher.TestLauncher.test_search_major_3

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\test\test_launcher.py", line 445, in test_search_major_3
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\test\test_launcher.py", line 465, in test_search_major_2
    self.assertEqual("PythonCore", data["env.company"])
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'PythonCore' != 'PythonTestSuite'
- PythonCore
+ PythonTestSuite

@hugovk

hugovk commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

Buildbot failure unrelated: likely a problem with the buildbot state requiring a restart.

@hugovk hugovk mentioned this pull request Nov 29, 2025
Open
@hroncok hroncok mentioned this pull request Feb 18, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@aisk aisk aisk left review comments

@vsajip vsajip vsajip approved these changes

@vstinner vstinner vstinner approved these changes

@merwok merwok

@savannahostrowski savannahostrowski savannahostrowski approved these changes

@sethmlarson sethmlarson sethmlarson approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@hugovk @sethmlarson @bedevere-bot @vsajip @vstinner @encukou @merwok @aisk @savannahostrowski @Lion101-debug