◐ Shell
reader mode source ↗
Skip to content

cross port importlib-metadata PR #76#13903

Merged
warsaw merged 1 commit into
python:masterfrom
asottile:importlib_metadata_cross_port_PR_76
Jun 7, 2019
Merged

cross port importlib-metadata PR #76#13903
warsaw merged 1 commit into
python:masterfrom
asottile:importlib_metadata_cross_port_PR_76

Conversation

@asottile

@asottile asottile commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

@asottile

asottile commented Jun 7, 2019

Copy link
Copy Markdown
Contributor Author

(needs backport to 3.8 only)

@warsaw

warsaw commented Jun 7, 2019

Copy link
Copy Markdown
Member

@Mariatta Interesting buglet: If I add two labels at the same time (i.e. skip-news and skip-issue), it seems like the bot only gets one of them. I had to unapply skip-news and then reapply it.

@Mariatta

Mariatta commented Jun 7, 2019

Copy link
Copy Markdown
Member

Hmm this might be a GitHub related issue, a race condition of some sort..

@warsaw warsaw merged commit 65e5860 into python:master Jun 7, 2019
@bedevere-bot

bedevere-bot commented Jun 7, 2019

Copy link
Copy Markdown

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

miss-islington commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

Thanks @asottile for the PR, and @warsaw for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@warsaw

warsaw commented Jun 7, 2019

Copy link
Copy Markdown
Member

Hmm this might be a GitHub related issue, a race condition of some sort..

Yeah, probably

@bedevere-bot

bedevere-bot commented Jun 7, 2019

Copy link
Copy Markdown

GH-13904 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 7, 2019
@miss-islington @asottile
cross port importlib-metadata PR GH-76 (GH-13903) …
3b5bac2 
https://gitlab.com/python-devs/importlib_metadata/merge_requests/76
(cherry picked from commit 65e5860)

Co-authored-by: Anthony Sottile <asottile@umich.edu>
@asottile asottile deleted the importlib_metadata_cross_port_PR_76 branch June 7, 2019 22:04
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asottile @DinoV
cross port importlib-metadata PR python#76 (python#13903) …
f54c885 
https://gitlab.com/python-devs/importlib_metadata/merge_requests/76
@jaraco jaraco mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@asottile @warsaw @Mariatta @bedevere-bot @miss-islington @the-knights-who-say-ni