◐ Shell
reader mode source ↗
Skip to content

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [locks]#13920

Merged
miss-islington merged 5 commits into
python:masterfrom
eamanu:bpo-36373-lock
Sep 10, 2019
Merged

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [locks]#13920
miss-islington merged 5 commits into
python:masterfrom
eamanu:bpo-36373-lock

Conversation

@eamanu

@eamanu eamanu commented Jun 8, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py

https://bugs.python.org/issue36373

Automerge-Triggered-By: @asvetlov

@eamanu
Deprecate explicit loop parameter asyncio …
73f32d0 
This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py
@eamanu eamanu requested review from 1st1 and asvetlov as code owners June 8, 2019 17:49
@eamanu

eamanu commented Jun 9, 2019

Copy link
Copy Markdown
Contributor Author

Please don't merge because ./python -Werror -m test -v test_asyncio is fallling

@eamanu eamanu requested a review from rhettinger as a code owner June 10, 2019 22:28
@eamanu

eamanu commented Jun 10, 2019

Copy link
Copy Markdown
Contributor Author

@asvetlov I think this PR is ready now

----------------------------------------------------------------------

Ran 2153 tests in 81.037s

OK (skipped=35)
test_asyncio passed in 1 min 21 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 min 21 sec
Tests result: SUCCESS

@eamanu eamanu mentioned this pull request Jun 10, 2019
Merged
@eamanu

eamanu commented Jun 22, 2019

Copy link
Copy Markdown
Contributor Author

ping @asvetlov :-)

@eamanu

eamanu commented Aug 5, 2019

Copy link
Copy Markdown
Contributor Author

ping @asvetlov

asvetlov
asvetlov approved these changes Sep 10, 2019
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM
Sorry for the delay.
Thank for your patience.

@miss-islington miss-islington merged commit 537877d into python:master Sep 10, 2019
@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@eamanu @miss-islington
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP… …
a313a7a 
…Is [locks] (pythonGH-13920)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py

https://bugs.python.org/issue36373
(cherry picked from commit 537877d)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15835 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 10, 2019
@miss-islington @eamanu
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP… …
bb8fc8b 
…Is [locks] (GH-13920)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py

https://bugs.python.org/issue36373
(cherry picked from commit 537877d)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@eamanu @websurfer5
bpo-36373: Deprecate explicit loop parameter in all public asyncio A… …
cfc33bd 
…PIs [locks] (pythonGH-13920)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

Third step: locks.py





https://bugs.python.org/issue36373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@rhettinger rhettinger

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eamanu @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni