◐ Shell
reader mode source ↗
Skip to content

gh-74857, PEP 538: Coerce POSIX locale to UTF-8 based locale#139238

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:posix_locale
Sep 23, 2025
Merged

gh-74857, PEP 538: Coerce POSIX locale to UTF-8 based locale#139238
vstinner merged 2 commits into
python:mainfrom
vstinner:posix_locale

Conversation

@vstinner

@vstinner vstinner commented Sep 22, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Sep 22, 2025
Closed
@vstinner

vstinner commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

cc @ncoghlan

ncoghlan
ncoghlan reviewed Sep 22, 2025
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Looks good to me, but there's a now-outdated Linux-specific setup clause in the test code that should be removed (we used to only test POSIX on Linux systems, but with it being added to the cross-platform set, we don't need to test it a second time).

@vstinner

vstinner commented Sep 23, 2025

Copy link
Copy Markdown
Member Author

@ncoghlan: Please review the updated PR.

ncoghlan
ncoghlan approved these changes Sep 23, 2025
View reviewed changes

@ncoghlan ncoghlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM!

Hide details View details @vstinner vstinner merged commit e8382e5 into python:main Sep 23, 2025
49 checks passed
@vstinner vstinner deleted the posix_locale branch September 23, 2025 17:21
@vstinner

vstinner commented Sep 23, 2025

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @ncoghlan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @ncoghlan