◐ Shell
reader mode source ↗
Skip to content

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [queue]#13950

Merged
miss-islington merged 1 commit into
python:masterfrom
eamanu:bpo-36373-queue
Sep 10, 2019
Merged

bpo-36373: Deprecate explicit loop parameter in all public asyncio APIs [queue]#13950
miss-islington merged 1 commit into
python:masterfrom
eamanu:bpo-36373-queue

Conversation

@eamanu

@eamanu eamanu commented Jun 10, 2019 •
edited by miss-islington
Loading

Copy link
Copy Markdown
Contributor

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373

Automerge-Triggered-By: @asvetlov

@eamanu
Deprecate explicit loop in all public asyncio …
37f7f53 
This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py
@eamanu eamanu requested a review from rhettinger as a code owner June 10, 2019 23:39
@eamanu

eamanu commented Jun 10, 2019

Copy link
Copy Markdown
Contributor Author

This PR depends of the tests fixed on #13920. #13920 should be merged first.

@eamanu

eamanu commented Jun 10, 2019

Copy link
Copy Markdown
Contributor Author

CC: @asvetlov

@MakDon

MakDon commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

LGTM. :D

@eamanu

eamanu commented Jun 22, 2019

Copy link
Copy Markdown
Contributor Author

ping @asvetlov :-)

@eamanu

eamanu commented Aug 5, 2019

Copy link
Copy Markdown
Contributor Author

ping @asvetlov

asvetlov
asvetlov approved these changes Sep 10, 2019
View reviewed changes

@asvetlov asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Thanks

@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit 9008be3 into python:master Sep 10, 2019
@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

@eamanu: Status check is done, and it's a success ✅ .

@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Thanks @eamanu for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2019
@eamanu @miss-islington
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP… …
33d2b76 
…Is [queue] (pythonGH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373
(cherry picked from commit 9008be3)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
@bedevere-bot

bedevere-bot commented Sep 10, 2019

Copy link
Copy Markdown

GH-15841 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 10, 2019
@miss-islington @eamanu
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP… …
55daf1a 
…Is [queue] (GH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373
(cherry picked from commit 9008be3)

Co-authored-by: Emmanuel Arias <emmanuelarias30@gmail.com>
tirkarthi pushed a commit to tirkarthi/cpython that referenced this pull request Sep 27, 2019
@eamanu @tirkarthi
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP… …
35f826c 
…Is [queue] (pythonGH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py

https://bugs.python.org/issue36373
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@eamanu @websurfer5
bpo-36373: Deprecate explicit loop parameter in all public asyncio AP… …
d433e89 
…Is [queue] (pythonGH-13950)

This PR deprecate explicit loop parameters in all public asyncio APIs

This issues is split to be easier to review.

fourth step: queue.py





https://bugs.python.org/issue36373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

+1 more reviewer

@MakDon MakDon MakDon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eamanu @MakDon @miss-islington @bedevere-bot @asvetlov @the-knights-who-say-ni