◐ Shell
reader mode source ↗
Skip to content

Lib/idlelib: remove commented out duplicate code#140259

Merged
terryjreedy merged 1 commit into
python:mainfrom
StanFromIreland:dedupe-idletestinit
Oct 19, 2025
Merged

Lib/idlelib: remove commented out duplicate code#140259
terryjreedy merged 1 commit into
python:mainfrom
StanFromIreland:dedupe-idletestinit

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Oct 17, 2025 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Member

No issue. Backports merged. Done.

@StanFromIreland StanFromIreland added skip issue skip news type-refactor Code refactoring (with no changes in behavior) labels Oct 17, 2025
@terryjreedy terryjreedy added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 19, 2025
@terryjreedy

terryjreedy commented Oct 19, 2025

Copy link
Copy Markdown
Member

I added most of the duplicated code and all of the comment in PR #104463, which was mostly about editing 2 other files. I changed 'package_tests' to 'module_tests' from the original code. I don't remember why but must have wanted to be able to experiment further without losing the near original, and forgot to remove it. Thanks for the PR.

Hide details View details @terryjreedy terryjreedy merged commit 790cdae into python:main Oct 19, 2025
55 checks passed
@miss-islington-app

miss-islington-app Bot commented Oct 19, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2025
@StanFromIreland @miss-islington
Lib/idlelib/idle_test/__init__.py: remove commented out duplicate c… …
d857758 
…ode (pythonGH-140259)

(cherry picked from commit 790cdae)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 19, 2025
@StanFromIreland @miss-islington
Lib/idlelib/idle_test/__init__.py: remove commented out duplicate c… …
b13d753 
…ode (pythonGH-140259)

(cherry picked from commit 790cdae)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Oct 19, 2025

Copy link
Copy Markdown

GH-140322 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 19, 2025
@bedevere-app

bedevere-app Bot commented Oct 19, 2025

Copy link
Copy Markdown

GH-140323 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Oct 19, 2025
@StanFromIreland StanFromIreland deleted the dedupe-idletestinit branch October 19, 2025 07:36
terryjreedy pushed a commit that referenced this pull request Oct 19, 2025
@miss-islington @StanFromIreland
[3.14] Lib/idlelib/idle_test/__init__.py: remove commented out dupl… …
69d263c 
…icate code (GH-140259) (#140322)

`Lib/idlelib/idle_test/__init__.py`: remove commented out duplicate code (GH-140259)
(cherry picked from commit 790cdae)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
terryjreedy pushed a commit that referenced this pull request Oct 19, 2025
@miss-islington @StanFromIreland
[3.13] Lib/idlelib/idle_test/__init__.py: remove commented out dupl… …
b2ed70f 
…icate code (GH-140259) (#140323)

`Lib/idlelib/idle_test/__init__.py`: remove commented out duplicate code (GH-140259)
(cherry picked from commit 790cdae)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland
Lib/idlelib/idle_test/__init__.py: remove commented out duplicate c… …
c105115 
…ode (python#140259)
@terryjreedy terryjreedy moved this to Done in IDLE Issues Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

No one assigned

Labels

skip issue skip news type-refactor Code refactoring (with no changes in behavior)

Projects

IDLE Issues
Status: Done +1 more

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @terryjreedy