gh-76007: Deprecate __version__ attribute in decimal#140302
Conversation
Sorry, something went wrong.
Co-authored-by: Victor Stinner <vstinner@python.org>
|
(Please edit the commit message when merging so that we’re not tagged forever by pushes in clones! thanks 🙂) |
Sorry, something went wrong.
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Éric, all of my commits up to that point had the commit message "Commit"? I tagged you in the PR description, I don't think that should be a burden for longer than this PR is open? There is an "unsubscribe" button in the right sidebar. |
Sorry, something went wrong.
skirpichev
left a comment
There was a problem hiding this comment.
Looks good, modulo one nitpick about decimal.rst.
I'm not sure also about naming for the constant. But lets see what other people think.
Sorry, something went wrong.
It seems core devs sometimes use PR descriptions for commit messages. So, it's rather a reminder for one, who will merge this pr. |
Sorry, something went wrong.
hugovk
left a comment
There was a problem hiding this comment.
I'm not sure also about naming for the constant. But lets see what other people think.
decimal.SPEC_VERSION is fine by me. Skip also suggested it at #76007 (comment).
Sorry, something went wrong.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
00026d1
into
python:main
Oct 26, 2025
|
Merged, thank you. |
Sorry, something went wrong.
|
Oh, importing $ ./python -Werror -c "import decimal"
Traceback (most recent call last):
File "<string>", line 1, in <module>
import decimal
File "/home/vstinner/python/main/Lib/decimal.py", line 103, in <module>
from _decimal import __version__ # noqa: F401
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
DeprecationWarning: '__version__' is deprecated and slated for removal in Python 3.20 |
Sorry, something went wrong.
|
Oh, ignore my previous comment, I forgot to run |
Sorry, something went wrong.
…n#140302) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Per discussion in the issue, provide a
SPEC_VERSIONconstant instead. CC @merwok @smontanaro📚 Documentation preview 📚: https://cpython-previews--140302.org.readthedocs.build/