◐ Shell
reader mode source ↗
Skip to content

gh-140550: Initial implementation of PEP 793 – PyModExport#140556

Merged
encukou merged 87 commits into
python:mainfrom
encukou:modexport-rebased
Nov 5, 2025
Merged

gh-140550: Initial implementation of PEP 793 – PyModExport#140556
encukou merged 87 commits into
python:mainfrom
encukou:modexport-rebased

Conversation

@encukou

@encukou encukou commented Oct 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This adds the initial implementation of PEP-793.
See the issue for follow-up tasks.

@encukou
Define PyMODEXPORT_FUNC
4ad95be
@encukou
Add new state to module object
c53650d
@encukou
Make sure the module def matches the state
9564e20
@encukou
Add simple test case
05a87c3
@encukou
Add new slot definitions
57c4f1e
@encukou
Modules are bigger sue me
956c59a
@encukou
Add a test for PyModule_FromSlotsAndSpec
14a66d2
@encukou
Add PyModule_FromSlotsAndSpec (empty for now)
72a27f5
@encukou
Add module test
b54293b
@encukou
Fill in enough of a PyModuleDef to pass to common machinery
fcc68f8
@encukou
Pass in a spec
3ab607e
@encukou
Rename field which can now be NULL
35d7d51
@encukou
Common implementation for PyModule_From{Def,Slots}AndSpec …
6fbbc18 
This uses a "def-like" structure: a PyModuleDef* that's not a valid
Python object.
@encukou
Add test for Py_mod_name slot
7207e07
@encukou
Handle Py_mod_name
8d4d264
@encukou
Test repeated slot
bd61e5b
@encukou
Test Py_mod_name with a def
d638abf
@encukou
Py_mod_doc
b24e6a6
@encukou
Disallow NULL slot value
756cbff
@encukou
Test repeats and NULL for all new slots
320de14
@encukou
Add PyModule_GetSize
4d88cf3
@encukou
Test size
a1d3c15
@encukou
Handle size
7fcee67
@encukou
Test new slots with PyModuleDef
9fd1e7e
@encukou
Py_mod_methods
fd95984
@encukou
GC hooks
748e18f
@encukou
Py_mod_token
1101f55
@encukou
Py_mod_exec
488eae7
@encukou
Clean up slot-handling a bit
f9d0dde
@encukou
Py_mod_create
020dcc6
89 hidden items Load more…
encukou
encukou commented Oct 28, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you for the initial review!

Yes, but there's a lot of tests. And I've also renamed things that changed semantics, so unrelated changes/backports will conflict or fail to build, rather than merge cleanly at the Git level but be subtly broken.

@encukou

encukou commented Oct 28, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64.FreeBSD.Refleaks

@bedevere-bot

bedevere-bot commented Oct 28, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 01d52ba 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140556%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.FreeBSD.Refleaks

The builders matched are:

  • AMD64 FreeBSD Refleaks PR

@encukou

encukou commented Oct 29, 2025

Copy link
Copy Markdown
Member Author

Do you plan to add documentation in a separated PR?

Yes. There's a lot to add since the PEP calls for soft-deprecation of PyInit_; see the issue.

encukou and others added 2 commits November 3, 2025 14:52
@encukou @kumaraditya303
Get the spaces just right …
26b57f2 
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@encukou
Merge branch 'main' into modexport-rebased
66e8309
vstinner
vstinner approved these changes Nov 4, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. Just please move _PyModule_GetGCHooks() to pycore_moduleobject.h.

@encukou

encukou commented Nov 5, 2025

Copy link
Copy Markdown
Member Author

Thank you for the review!

Hide details View details @encukou encukou merged commit 589a03a into python:main Nov 5, 2025
46 checks passed
@encukou encukou deleted the modexport-rebased branch November 5, 2025 11:31
@vstinner

vstinner commented Nov 5, 2025

Copy link
Copy Markdown
Member

Congrats :-)

@vstinner

vstinner commented Nov 5, 2025

Copy link
Copy Markdown
Member

make check-limited-abi does now fail on the main branch:

./python -E ./Tools/build/generate-build-details.py `cat pybuilddir.txt`/build-details.json
Checked 115 modules (37 built-in, 77 shared, 1 n/a on linux-x86_64, 0 disabled, 0 missing, 0 failed on import)
./python ./Tools/build/stable_abi.py --all
File /home/vstinner/python/main/Doc/data/stable_abi.dat differs from expected!
--- /home/vstinner/python/main/Doc/data/stable_abi.dat
+++ <expected>
@@ -979,14 +979,6 @@
 type,Py_buffer,3.11,,full-abi
 type,Py_intptr_t,3.2,,
 macro,Py_mod_abi,3.15,,
-macro,Py_mod_doc,3.15,,
-macro,Py_mod_methods,3.15,,
-macro,Py_mod_name,3.15,,
-macro,Py_mod_state_clear,3.15,,
-macro,Py_mod_state_free,3.15,,
-macro,Py_mod_state_size,3.15,,
-macro,Py_mod_state_traverse,3.15,,
-macro,Py_mod_token,3.15,,
 macro,Py_mp_ass_subscript,3.2,,
 macro,Py_mp_length,3.2,,
 macro,Py_mp_subscript,3.2,,

I created #141056 to fix the issue.

@encukou

encukou commented Nov 5, 2025

Copy link
Copy Markdown
Member Author

Thank you!

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@encukou @vstinner
@kumaraditya303 @StanFromIreland
pythongh-140550: Initial implementation of PEP 793 – PyModExport (pyt… …
7e30dee 
…honGH-140556)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
@ngoldbaum ngoldbaum mentioned this pull request Jan 15, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@emmatyping emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou @bedevere-bot @vstinner @kumaraditya303