◐ Shell
reader mode source ↗
Skip to content

[3.14] gh-140104: Revert "Set next_instr properly in the JIT during exceptions (GH-140233) (GH-140687)"#140890

Merged
Fidget-Spinner merged 1 commit into
python:3.14from
Fidget-Spinner:revert-2e21672
Nov 1, 2025
Merged

[3.14] gh-140104: Revert "Set next_instr properly in the JIT during exceptions (GH-140233) (GH-140687)"#140890
Fidget-Spinner merged 1 commit into
python:3.14from
Fidget-Spinner:revert-2e21672

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Nov 1, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Nov 1, 2025
Closed
@Fidget-Spinner Fidget-Spinner changed the title gh-140104: Revert 2e21672 Nov 1, 2025
@efimov-mikhail

efimov-mikhail commented Nov 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Sorry, I don't fully understand, which CI was red?

For me on 3.14 all work as expected.
But, of course, I can miss something due to very little experience with JIT.

@efimov-mikhail

efimov-mikhail commented Nov 1, 2025

Copy link
Copy Markdown
Member

Oh, I've found some bad run:
https://github.com/python/cpython/actions/runs/18999446540/job/54264041076

@efimov-mikhail

efimov-mikhail commented Nov 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Yes, there's a problem with one JIT test on current 3.14 branch, test.test_capi.test_opt.TestUopsOptimization.test_next_ instr_for_exception_handler_set.

And there's no such problem on main.

iOS problem is unrelated.
We can merge this and further investigate what should be done for 3.14 (if we want to, since JIT is experimental for now).

@picnixz picnixz changed the title [3.14] gh-140104: Revert 2e21672 Nov 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 1, 2025
Merged
Hide details View details @Fidget-Spinner Fidget-Spinner merged commit 4d68b75 into python:3.14 Nov 1, 2025
92 of 94 checks passed
@Fidget-Spinner Fidget-Spinner deleted the revert-2e21672 branch November 1, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efimov-mikhail efimov-mikhail efimov-mikhail approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fidget-Spinner @efimov-mikhail