◐ Shell
reader mode source ↗
Skip to content

bpo-37289: Remove 'if False' handling in the peephole optimizer#14099

Merged
pablogsal merged 2 commits into
python:masterfrom
pablogsal:bpo-37289
Jun 15, 2019
Merged

bpo-37289: Remove 'if False' handling in the peephole optimizer#14099
pablogsal merged 2 commits into
python:masterfrom
pablogsal:bpo-37289

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 15, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal self-assigned this Jun 15, 2019
@pablogsal pablogsal changed the title Remove 'if False' handling in the peephole optimizer Jun 15, 2019
@pablogsal pablogsal changed the title bpo-37289; Remove 'if False' handling in the peephole optimizer Jun 15, 2019
serhiy-storchaka
serhiy-storchaka reviewed Jun 15, 2019
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

What if PyObject_IsTrue() returns -1?

@pablogsal

pablogsal commented Jun 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Member Author

@serhiy-storchaka It goes to the break and skips to the next bytecode, right? I am missing something?

@serhiy-storchaka

serhiy-storchaka commented Jun 15, 2019

Copy link
Copy Markdown
Member

It should be handled as an error.

@pablogsal

pablogsal commented Jun 15, 2019

Copy link
Copy Markdown
Member Author

@serhiy-storchaka Done in 455cbc7

@pablogsal pablogsal merged commit 7a68f8c into python:master Jun 15, 2019
@miss-islington

miss-islington commented Jun 15, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jun 15, 2019

Copy link
Copy Markdown
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@pablogsal pablogsal deleted the bpo-37289 branch June 15, 2019 14:58
@bedevere-bot

bedevere-bot commented Jun 15, 2019

Copy link
Copy Markdown

GH-14111 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2019
@pablogsal @miss-islington
bpo-37289: Remove 'if False' handling in the peephole optimizer (pyth… …
c45f8e2 
…onGH-14099)

(cherry picked from commit 7a68f8c)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@miss-islington

miss-islington commented Jun 15, 2019

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 15, 2019

Copy link
Copy Markdown

GH-14112 is a backport of this pull request to the 3.8 branch.

pablogsal added a commit that referenced this pull request Jun 15, 2019
@miss-islington @pablogsal
bpo-37289: Remove 'if False' handling in the peephole optimizer (GH-1… …
284daea 
…4099) (GH-14112)

(cherry picked from commit 7a68f8c)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jun 15, 2019
@miss-islington @pablogsal
bpo-37289: Remove 'if False' handling in the peephole optimizer (GH-1… …
81fecf7 
…4099) (GH-14111)

(cherry picked from commit 7a68f8c)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@pablogsal @lisroach
bpo-37289: Remove 'if False' handling in the peephole optimizer (pyth… …
d7d6b1c 
…onGH-14099)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@pablogsal @DinoV
bpo-37289: Remove 'if False' handling in the peephole optimizer (pyth… …
d8134cf 
…onGH-14099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka

@vstinner vstinner

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni