◐ Shell
reader mode source ↗
Skip to content

gh-141004: Document PyLong_FromPid and PyLong_AsPid#141028

Merged
ZeroIntensity merged 4 commits into
python:mainfrom
ZeroIntensity:document-pylong-pid
Nov 6, 2025
Merged

gh-141004: Document PyLong_FromPid and PyLong_AsPid#141028
ZeroIntensity merged 4 commits into
python:mainfrom
ZeroIntensity:document-pylong-pid

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added awaiting core review docs Documentation in the Doc dir skip news labels Nov 4, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Nov 4, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 4, 2025
Open
@encukou

encukou commented Nov 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Perhaps deprecate this in favour of PyLong_AsNativeBytes with sizeof(pid_t)? (Platforms like Windows don't have pid_t, but to use this function you need to know the type for your platform anyway.)

@ZeroIntensity

ZeroIntensity commented Nov 4, 2025

Copy link
Copy Markdown
Member Author

No objection from me, but we should still document things like this for completeness (even if it's just to say "use this other thing instead"). Would you mind adding things to (soft) deprecate on the list I created at capi-workgroup/decisions#86?

ZeroIntensity and others added 3 commits November 6, 2025 08:42
@ZeroIntensity @vstinner
Update Doc/c-api/long.rst …
d9cff4b 
Co-authored-by: Victor Stinner <vstinner@python.org>
@ZeroIntensity @vstinner
Update Doc/c-api/long.rst …
7fbbdcf 
Co-authored-by: Victor Stinner <vstinner@python.org>
@ZeroIntensity
Add versionadded notes.
9cadc91
vstinner
vstinner approved these changes Nov 6, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM.

If they become (soft) deprecated, it can be done in a separated PR.

@ZeroIntensity

ZeroIntensity commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

Yeah, and the deprecation won't be backported either. Thanks for the review!

Hide details View details @ZeroIntensity ZeroIntensity merged commit bcc524f into python:main Nov 6, 2025
32 checks passed
@ZeroIntensity ZeroIntensity deleted the document-pylong-pid branch November 6, 2025 14:01
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 6, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2025
@ZeroIntensity @vstinner @miss-islington
pythongh-141004: Document PyLong_FromPid and PyLong_AsPid (python… …
7e0635f 
…GH-141028)

(cherry picked from commit bcc524f)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app

bedevere-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

GH-141142 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

Sorry, @ZeroIntensity, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bcc524f82d8548707046ce90f5bc56f60018767a 3.13

@bedevere-app

bedevere-app Bot commented Nov 6, 2025

Copy link
Copy Markdown

GH-141143 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 6, 2025
ZeroIntensity added a commit to ZeroIntensity/cpython that referenced this pull request Nov 6, 2025
@ZeroIntensity @vstinner
pythongh-141004: Document PyLong_FromPid and PyLong_AsPid (python… …
00f148b 
…GH-141028)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit bcc524f)
ZeroIntensity added a commit to ZeroIntensity/cpython that referenced this pull request Nov 6, 2025
@ZeroIntensity @vstinner
[3.13] pythongh-141004: Document PyLong_FromPid and PyLong_AsPid (p… …
dfa521b 
…ythonGH-141028)

(cherry picked from commit bcc524f)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
ZeroIntensity added a commit that referenced this pull request Nov 6, 2025
@miss-islington @ZeroIntensity @vstinner
[3.14] gh-141004: Document PyLong_FromPid and PyLong_AsPid (GH-14… …
5d10409 
…1028) (GH-141142)

gh-141004: Document `PyLong_FromPid` and `PyLong_AsPid` (GH-141028)
(cherry picked from commit bcc524f)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
ZeroIntensity added a commit that referenced this pull request Nov 6, 2025
@ZeroIntensity @vstinner
[3.13] gh-141004: Document PyLong_FromPid and PyLong_AsPid (GH-14… …
908695b 
…1028) (GH-141143)

* gh-141004: Document `PyLong_FromPid` and `PyLong_AsPid` (GH-141028)

Co-authored-by: Victor Stinner <vstinner@python.org>
(cherry picked from commit bcc524f)
beneltayar pushed a commit to beneltayar/cpython that referenced this pull request Nov 6, 2025
@ZeroIntensity @vstinner @benel-tayar-bd
pythongh-141004: Document PyLong_FromPid and PyLong_AsPid (python… …
1b57d39 
…GH-141028)

Co-authored-by: Victor Stinner <vstinner@python.org>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@ZeroIntensity @vstinner @StanFromIreland
pythongh-141004: Document PyLong_FromPid and PyLong_AsPid (python… …
70f0897 
…GH-141028)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

@ZeroIntensity ZeroIntensity

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZeroIntensity @encukou @vstinner