◐ Shell
reader mode source ↗
Skip to content

gh-141004: deprecate Py_MATH_El and Py_MATH_PIl macros#141035

Merged
vstinner merged 4 commits into
python:mainfrom
skirpichev:deprecate-consts/141004
Nov 10, 2025
Merged

gh-141004: deprecate Py_MATH_El and Py_MATH_PIl macros#141035
vstinner merged 4 commits into
python:mainfrom
skirpichev:deprecate-consts/141004

Conversation

@skirpichev

@skirpichev skirpichev commented Nov 5, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@skirpichev skirpichev requested a review from AA-Turner as a code owner November 5, 2025 02:54
@bedevere-app bedevere-app Bot mentioned this pull request Nov 5, 2025
Open
@skirpichev

skirpichev commented Nov 5, 2025

Copy link
Copy Markdown
Member Author

CC @ZeroIntensity, @vstinner

@skirpichev @vstinner
Apply suggestions from code review …
fd0ebd8 
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner

vstinner commented Nov 5, 2025

Copy link
Copy Markdown
Member

A code search in PyPI top 15,000 found no matching line:

$ ./search_pypi_top.py PYPI-2025-09-22/ 'Py_MATH_PIl|Py_MATH_El' -o Py_MATH_PIl -q

Time: 0:01:39.505584
Found 0 matching lines in 0 projects
Output written into: Py_MATH_PIl

vstinner
vstinner approved these changes Nov 5, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

ZeroIntensity
ZeroIntensity approved these changes Nov 5, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM as well.

Hide details View details @vstinner vstinner merged commit 88953d5 into python:main Nov 10, 2025
46 checks passed
@skirpichev skirpichev deleted the deprecate-consts/141004 branch November 11, 2025 10:27
@skirpichev skirpichev mentioned this pull request Nov 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev @vstinner @ZeroIntensity