◐ Shell
reader mode source ↗
Skip to content

gh-140947: fix contextvars handling for server tasks in asyncio #141158

Merged
kumaraditya303 merged 17 commits into
python:mainfrom
kumaraditya303:asyncio-contextvars-fix
Mar 21, 2026
Merged

gh-140947: fix contextvars handling for server tasks in asyncio #141158
kumaraditya303 merged 17 commits into
python:mainfrom
kumaraditya303:asyncio-contextvars-fix

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Nov 6, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Nov 6, 2025
Open
@Kludex

Kludex commented Nov 17, 2025

Copy link
Copy Markdown

Any chance this can be considered a security issue?

@kumaraditya303

kumaraditya303 commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

Any chance this can be considered a security issue?

There are a lot of moving parts in fixing this and this PR only fixes the non-ssl part, ssl remains remains to be fixed.
IMO it is too risky to backport to security branches, I am in favor of backport to bug-fixes branches after a careful review.

@pmeier pmeier mentioned this pull request Nov 21, 2025
Merged
3 tasks
@kumaraditya303 kumaraditya303 force-pushed the asyncio-contextvars-fix branch from 6354b14 to f845484 Compare January 13, 2026 14:20
@kumaraditya303 kumaraditya303 marked this pull request as ready for review March 21, 2026 06:50
@kumaraditya303 kumaraditya303 added topic-asyncio 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Mar 21, 2026
@bedevere-bot

bedevere-bot commented Mar 21, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit a2039d6 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141158%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 21, 2026
@vstinner

vstinner commented Mar 21, 2026

Copy link
Copy Markdown
Member

I restarted the buildbot server. It seems like buildbot workers are now working properly again.

Hide details View details @kumaraditya303 kumaraditya303 merged commit 60fbc20 into python:main Mar 21, 2026
85 of 87 checks passed
@kumaraditya303 kumaraditya303 deleted the asyncio-contextvars-fix branch March 21, 2026 12:14
@pablogsal pablogsal mentioned this pull request Apr 4, 2026
Merged
@Kludex Kludex mentioned this pull request Apr 21, 2026
Merged
4 tasks
Kludex added a commit to Kludex/uvicorn that referenced this pull request Apr 21, 2026
@Kludex
Add --reset-contextvars flag to isolate ASGI request context …
7875420 
Reintroduces the behavior from #2742 as an opt-in flag. When set, each
ASGI request runs in a fresh contextvars.Context, which works around
the asyncio context leak in python/cpython#140947
(expected to be fixed upstream for Python >=3.15 via python/cpython#141158).

Default is off so context set in the lifespan or by external
instrumentation (e.g. OpenTelemetry eBPF propagation) remains visible
to ASGI handlers.
@Kludex Kludex mentioned this pull request Apr 21, 2026
Merged
6 tasks
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@kumaraditya303 @ljfp
pythongh-140947: fix contextvars handling for server tasks in asyncio (… …
97e41ae 
…python#141158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kumaraditya303 @Kludex @bedevere-bot @vstinner @nazeerali4325-commits