◐ Shell
reader mode source ↗
Skip to content

bpo-30241: implement contextlib.AbstractAsyncContextManager#1412

Merged
1st1 merged 6 commits into
python:masterfrom
JelleZijlstra:aacm
Dec 14, 2017
Merged

bpo-30241: implement contextlib.AbstractAsyncContextManager#1412
1st1 merged 6 commits into
python:masterfrom
JelleZijlstra:aacm

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 3, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@mention-bot

mention-bot commented May 3, 2017

Copy link
Copy Markdown

@JelleZijlstra, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ncoghlan, @birkenfeld and @rhettinger to be potential reviewers.

@gvanrossum

gvanrossum commented Jun 9, 2017

Copy link
Copy Markdown
Member

Wait, isn't this a new feature that should go into 3.7?

@ilevkivskyi

ilevkivskyi commented Jun 9, 2017

Copy link
Copy Markdown
Member

Wait, isn't this a new feature that should go into 3.7?

Oh yes, sorry, this one is not urgent then.

@JelleZijlstra JelleZijlstra mentioned this pull request Jun 9, 2017
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Jun 24, 2017
@JelleZijlstra
add typing.AsyncContextManager and contextlib.asynccontextmanager …
32977e0 
Implements:
- python/typing#438
- python/cpython#360

python/cpython#1412, which adds
contextlib.AbstractAsyncContextManager, has not yet been merged.
@JelleZijlstra JelleZijlstra mentioned this pull request Jun 24, 2017
Merged
gvanrossum pushed a commit to python/typeshed that referenced this pull request Jun 27, 2017
@JelleZijlstra @gvanrossum
add typing.AsyncContextManager and contextlib.asynccontextmanager (#1432 …
22f47fd 
)

Implements:
- python/typing#438
- python/cpython#360

Note that python/cpython#1412, which adds
contextlib.AbstractAsyncContextManager, has not yet been merged.
@1st1

1st1 commented Oct 10, 2017

Copy link
Copy Markdown
Member

Please add a NEWS entry and I'll merge this in.

@JelleZijlstra

JelleZijlstra commented Oct 11, 2017

Copy link
Copy Markdown
Member Author

Thanks, just pushed a NEWS entry.

@Kentzo

Kentzo commented Dec 11, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

The PR #4790 adds AsyncExitStack subclass. It should inherit from AbstractAsyncContextManager.

@ilevkivskyi

ilevkivskyi commented Dec 13, 2017

Copy link
Copy Markdown
Member

@JelleZijlstra Could you please fix the merge conflict and update the docs as @1st1 proposed? I would like to have this merged soon.

@1st1 1st1 merged commit 176baa3 into python:master Dec 14, 2017
@1st1

1st1 commented Dec 14, 2017

Copy link
Copy Markdown
Member

Thanks @JelleZijlstra!

@JelleZijlstra JelleZijlstra deleted the aacm branch December 14, 2017 01:28
@JelleZijlstra

JelleZijlstra commented Dec 14, 2017

Copy link
Copy Markdown
Member Author

Thanks, and sorry for dropping the ball on making the docs change!

@1st1

1st1 commented Dec 14, 2017

Copy link
Copy Markdown
Member

NP ;)

@ilevkivskyi

ilevkivskyi commented Dec 14, 2017

Copy link
Copy Markdown
Member

Thank you @JelleZijlstra and @1st1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 approved these changes

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@JelleZijlstra @mention-bot @gvanrossum @ilevkivskyi @1st1 @Kentzo @the-knights-who-say-ni @bedevere-bot