{{ message }}
gh-141004: Document missing PyCFunction* and PyCMethod* APIs#141253
Merged
ZeroIntensity merged 8 commits intoNov 16, 2025
Merged
gh-141004: Document missing PyCFunction* and PyCMethod* APIs#141253ZeroIntensity merged 8 commits into
PyCFunction* and PyCMethod* APIs#141253ZeroIntensity merged 8 commits into
Conversation
Member
Sorry, something went wrong.
sharktide
reviewed
Nov 15, 2025
Contributor
There was a problem hiding this comment.
I suggested some updates so the tone is consistent (eg. We use trailing "s" chars like "returns" but we use "Get" instead of "Gets") so we should keep the same style for consistency and to improve reading flow
I also surrounded true and false with backticks
Sorry, something went wrong.
sharktide
approved these changes
Nov 15, 2025
sharktide
left a comment
sharktide
left a comment
Contributor
There was a problem hiding this comment.
In that case it looks fine to me / LGTM
Sorry, something went wrong.
picnixz
reviewed
Nov 15, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
reviewed
Nov 15, 2025
picnixz
reviewed
Nov 16, 2025
picnixz
approved these changes
Nov 16, 2025
ZeroIntensity
added
needs backport to 3.13
bugs and security fixes
needs backport to 3.14
labels
Nov 16, 2025
Hide details
View details
ZeroIntensity
merged commit
ZeroIntensity
merged commit be699d6
into
python:main
Nov 16, 2025
32 checks passed
|
Thanks @ZeroIntensity for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 16, 2025
pythonGH-141253) (cherry picked from commit be699d6) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 16, 2025
pythonGH-141253) (cherry picked from commit be699d6) Co-authored-by: Peter Bierma <zintensitydev@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
pythonGH-141253) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
📚 Documentation preview 📚: https://cpython-previews--141253.org.readthedocs.build/en/141253/c-api/structures.html#implementing-functions-and-methods