◐ Shell
reader mode source ↗
Skip to content

gh-141004: Document pyctype.h macros#141272

Merged
ZeroIntensity merged 3 commits into
python:mainfrom
StanFromIreland:pyctype
Nov 10, 2025
Merged

gh-141004: Document pyctype.h macros#141272
ZeroIntensity merged 3 commits into
python:mainfrom
StanFromIreland:pyctype

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Nov 8, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 8, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Nov 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 8, 2025
Open
ZeroIntensity
ZeroIntensity reviewed Nov 8, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

These seem like a candidate for soft deprecation, so please bring this up at capi-workgroup/decisions#86. I'm a bit surprised that they were intentionally added to the public API in 2.7, but character functions don't seem like CPython's job to support.

@StanFromIreland

StanFromIreland commented Nov 8, 2025

Copy link
Copy Markdown
Member Author

I concur, soft deprecation makes sense.

ZeroIntensity
ZeroIntensity approved these changes Nov 8, 2025
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks for dealing with these! I'm going to hold off on merging until Monday in case someone else has a strong opinion on these.

@StanFromIreland

StanFromIreland commented Nov 9, 2025

Copy link
Copy Markdown
Member Author

@malemburg maybe you would like to review?

Hide details View details @ZeroIntensity ZeroIntensity merged commit df19261 into python:main Nov 10, 2025
32 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Nov 10, 2025
@ZeroIntensity ZeroIntensity added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 10, 2025
@miss-islington-app

miss-islington-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland @miss-islington
pythongh-141004: Document pyctype.h macros (pythonGH-141272) …
c34a5d9 
(cherry picked from commit df19261)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

GH-141339 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Nov 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2025
@StanFromIreland @miss-islington
pythongh-141004: Document pyctype.h macros (pythonGH-141272) …
e8390d8 
(cherry picked from commit df19261)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Nov 10, 2025

Copy link
Copy Markdown

GH-141340 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 10, 2025
ZeroIntensity pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington @StanFromIreland
[3.13] gh-141004: Document pyctype.h macros (GH-141272) (GH-141339) …
9cbbb2e 
gh-141004: Document `pyctype.h` macros (GH-141272)
(cherry picked from commit df19261)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
ZeroIntensity pushed a commit that referenced this pull request Nov 10, 2025
@miss-islington @StanFromIreland
[3.14] gh-141004: Document pyctype.h macros (GH-141272) (GH-141340) …
c09a659 
gh-141004: Document `pyctype.h` macros (GH-141272)
(cherry picked from commit df19261)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland StanFromIreland deleted the pyctype branch November 10, 2025 15:54
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@StanFromIreland
pythongh-141004: Document pyctype.h macros (pythonGH-141272)
20026e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

@AA-Turner AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @ZeroIntensity