◐ Shell
reader mode source ↗
Skip to content

gh-140550: Remove PyInit function from test_cext#141511

Draft
encukou wants to merge 1 commit into
python:mainfrom
encukou:modexport-remove-pyinit-from-test_cext
Draft

gh-140550: Remove PyInit function from test_cext#141511
encukou wants to merge 1 commit into
python:mainfrom
encukou:modexport-remove-pyinit-from-test_cext

Conversation

@encukou

@encukou encukou commented Nov 13, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This should not be necessary, but let me ask the buildbots.

@bedevere-app bedevere-app Bot mentioned this pull request Nov 13, 2025
Open
25 tasks
vstinner
vstinner approved these changes Nov 13, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 14, 2025
@bedevere-bot

bedevere-bot commented Nov 14, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1ad68bf 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141511%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 14, 2025
@vstinner

vstinner commented Nov 14, 2025

Copy link
Copy Markdown
Member

FreeBSD failures are unrelated and should be fixed by #141551.

@vstinner

vstinner commented Nov 14, 2025

Copy link
Copy Markdown
Member

buildbot/AMD64 Windows PGO NoGIL PR
buildbot/AMD64 Windows11 Non-Debug PR

test_cext fails with:

  "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\bin\HostX86\x64\link.exe" /nologo /INCREMENTAL:NO /LTCG /DLL /MANIFEST:EMBED,ID=2 /MANIFESTUAC:NO /LIBPATH:C:\Users\Administrator\buildarea\pull_request.itamaro-win64-srv-22-aws.nogil.pgo\build\PCbuild\AMD64 /LIBPATH:C:\Users\Administrator\buildarea\pull_request.itamaro-win64-srv-22-aws.nogil.pgo\build\build\test_python_3776æ\tempcwd\env\libs /LIBPATH:C:\Users\Administrator\buildarea\pull_request.itamaro-win64-srv-22-aws.nogil.pgo\build\libs /LIBPATH:C:\Users\Administrator\buildarea\pull_request.itamaro-win64-srv-22-aws.nogil.pgo\build /LIBPATH:C:\Users\Administrator\buildarea\pull_request.itamaro-win64-srv-22-aws.nogil.pgo\build\build\test_python_3776æ\tempcwd\env\PCbuild\amd64 "/LIBPATH:C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.44.35207\lib\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\lib\10.0.26100.0\ucrt\x64" "/LIBPATH:C:\Program Files (x86)\Windows Kits\10\\lib\10.0.26100.0\\um\x64" /EXPORT:PyInit__test_cext build\temp.win-amd64-cpython-315t\Release\extension.obj /OUT:build\lib.win-amd64-cpython-315t\_test_cext.cp315t-win_amd64.pyd /IMPLIB:build\temp.win-amd64-cpython-315t\Release\_test_cext.cp315t-win_amd64.lib
  LINK : error LNK2001: unresolved external symbol PyInit__test_cext
  build\temp.win-amd64-cpython-315t\Release\_test_cext.cp315t-win_amd64.lib : fatal error LNK1120: 1 unresolved externals
  error: command 'C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.44.35207\\bin\\HostX86\\x64\\link.exe' failed with exit code 1120
  error: subprocess-exited-with-error

It looks like a legit error.

The (long) build command contains /EXPORT:PyInit__test_cext.

@encukou

encukou commented Nov 14, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

This one will need coordination with setuptools. Glad we found it early :)

Setuptools is adding an /EXPORT specification to the LINK command for the PyInit_* function.
This fails if there is no such function.

According to MSVC docs:

There are four methods for exporting a definition, listed in recommended order of use:

  1. __declspec(dllexport) in the source code
  2. An EXPORTS statement in a .def file
  3. An /EXPORT specification in a LINK command
  4. A comment directive in the source code, of the form #pragma comment(linker, "/export: definition ").

We should be using method (1). Once we do, setuptools can stop doing (3), perhaps conditionally.

@encukou encukou marked this pull request as draft November 14, 2025 15:59
@encukou

encukou commented Jan 13, 2026

Copy link
Copy Markdown
Member Author

setuptools/distutils PR: pypa/distutils#395

@github-actions

github-actions Bot commented May 2, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@encukou @bedevere-bot @vstinner @nazeerali4325-commits