◐ Shell
reader mode source ↗
Skip to content

bpo-28869: Skip one additional frame when type.__new__ is called not directly from type.__call__.#14166

Open
serhiy-storchaka wants to merge 8 commits into
python:mainfrom
serhiy-storchaka:type-call-set-module
Open

bpo-28869: Skip one additional frame when type.__new__ is called not directly from type.__call__.#14166
serhiy-storchaka wants to merge 8 commits into
python:mainfrom
serhiy-storchaka:type-call-set-module

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka
bpo-28869: Change some details in type(). …
6b14bb1 
* Move handling of one-argument call of type() from type.__new__() to type.__call__().
* Move deducing __module__ from the caller's frame from type.__new__() to type.__call__().
@brettcannon brettcannon added the type-bug An unexpected behavior, bug, or error label Jun 21, 2019
@ilevkivskyi

ilevkivskyi commented Aug 7, 2019

Copy link
Copy Markdown
Member

@serhiy-storchaka I like this approach, please let me know when this is ready for review (I assume tests are needed and some comments explaining this behavior).

@ilevkivskyi ilevkivskyi mentioned this pull request Aug 7, 2019
Open
@serhiy-storchaka

serhiy-storchaka commented Aug 7, 2019

Copy link
Copy Markdown
Member Author

Yes, it needs tests and documenting.

Also this PR contains actually two changes. I am not sure that both of them should be backported, but it is difficult to make one without making other.

@serhiy-storchaka

serhiy-storchaka commented Aug 7, 2019

Copy link
Copy Markdown
Member Author

I just have tested, and seems there is no undesired behavior change. So I just need to write tests and a NEWS entry.

@serhiy-storchaka

serhiy-storchaka commented Oct 7, 2019

Copy link
Copy Markdown
Member Author

Unfortunately it does not work. Not setting __module__ in the class dictionary does not help with the original issue, because __module__ will be looked up in the metaclass dictionary. Setting it in __call__() opens other questions and significantly complicates the code.

@serhiy-storchaka serhiy-storchaka changed the title [WIP] bpo-28869: Change some details in type(). Oct 13, 2019
ilevkivskyi
ilevkivskyi reviewed Oct 13, 2019
View reviewed changes

@ilevkivskyi ilevkivskyi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I have one question/comment. Also if we are going this way, I think this deserves a comment in the code explaining the motivation.

@ilevkivskyi

ilevkivskyi commented Nov 17, 2019

Copy link
Copy Markdown
Member

It looks like this may also fix https://bugs.python.org/issue37948

@serhiy-storchaka

serhiy-storchaka commented Mar 8, 2020

Copy link
Copy Markdown
Member Author

I am not sure it is a good solution.

@githorse githorse mentioned this pull request May 22, 2020
Closed
@github-actions

github-actions Bot commented Apr 7, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi left review comments

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE stale Stale PR or inactive for long period of time. type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @ilevkivskyi @brettcannon @the-knights-who-say-ni @ezio-melotti @bedevere-bot