◐ Shell
reader mode source ↗
Skip to content

gh-119786: Remove mention of _PyThreadState_BumpFramePointer from InternalDocs/interpreter.md#141816

Merged
hugovk merged 2 commits into
python:mainfrom
efimov-mikhail:issue-119786-interpreter-docs
Dec 16, 2025
Merged

gh-119786: Remove mention of _PyThreadState_BumpFramePointer from InternalDocs/interpreter.md#141816
hugovk merged 2 commits into
python:mainfrom
efimov-mikhail:issue-119786-interpreter-docs

Conversation

@efimov-mikhail

@efimov-mikhail efimov-mikhail commented Nov 21, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

In #93908 function _PyThreadState_BumpFramePointer was removed.
But we still have its mention in InternalDocs/interpreter.md.
I propose to remove it and slightly change wording around.
For example, functions _PyThreadState_HasStackSpace and _PyFrame_PushUnchecked could be mentioned.

CC @iritkatriel @markshannon

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 21, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Nov 21, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Nov 21, 2025
Closed
@efimov-mikhail efimov-mikhail requested review from iritkatriel and markshannon and removed request for AA-Turner November 21, 2025 08:55
@efimov-mikhail @iritkatriel
Update InternalDocs/interpreter.md …
7c78bb1 
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatriel

iritkatriel commented Nov 21, 2025

Copy link
Copy Markdown
Member

how far back does this needs back porting?

@efimov-mikhail efimov-mikhail added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 21, 2025
@efimov-mikhail

efimov-mikhail commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Thx for the review, @iritkatriel!

Backporting to 3.13 and 3.14 seems to be optimal, since this change was landed to 3.12, and docs changes are definitely not a security fixes.
I've added those labels.

@iritkatriel

iritkatriel commented Nov 21, 2025

Copy link
Copy Markdown
Member

we can back port doc updates to security fix versions

@efimov-mikhail efimov-mikhail removed the needs backport to 3.13 bugs and security fixes label Nov 21, 2025
@efimov-mikhail

efimov-mikhail commented Nov 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Actually, we can backport only to 3.14, since there's no InternalDocs/interpreter.md file on 3.13.
I forgot about it, sorry.

Hide details View details @hugovk hugovk merged commit cf7a309 into python:main Dec 16, 2025
38 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Dec 16, 2025
@miss-islington-app

miss-islington-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

Thanks @efimov-mikhail for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 16, 2025
@efimov-mikhail @iritkatriel @miss-islington
pythongh-119786: Remove mention of _PyThreadState_BumpFramePointer … …
7d0cb9b 
…from `InternalDocs/interpreter.md` (pythonGH-141816)

(cherry picked from commit cf7a309)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Dec 16, 2025

Copy link
Copy Markdown

GH-142812 is a backport of this pull request to the 3.14 branch.

hugovk pushed a commit that referenced this pull request Dec 16, 2025
@miss-islington @efimov-mikhail @iritkatriel
[3.14] gh-119786: Remove mention of _PyThreadState_BumpFramePointer… …
6545f24 
… from `InternalDocs/interpreter.md` (GH-141816) (#142812)

Co-authored-by: Mikhail Efimov <efimov.mikhail@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergey-miryanov sergey-miryanov sergey-miryanov approved these changes

@iritkatriel iritkatriel iritkatriel approved these changes

@markshannon markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

docs skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@efimov-mikhail @iritkatriel @sergey-miryanov @hugovk @nazeerali4325-commits