◐ Shell reader mode source ↗

gh-54872: Remove default OPT=-O for non-GCC compilers#142159

Open

bobzinin wants to merge 2 commits into

python:mainfrom

bobzinin:fix-opt-default

bobzinin commented Dec 1, 2025 •

edited

Loading

Copy link Copy Markdown

The configure script was setting OPT="-O" by default for non-GCC compilers, which could conflict with user-specified CFLAGS. This change removes the automatic default, allowing users full control over optimization flags via CFLAGS without unexpected conflicts.

Issue: configure shouldn't set a default OPT #54872


          Remove default OPT=-O for non-GCC compilers

…

e712a28

The configure script was setting OPT="-O" by default for non-GCC
compilers, which could conflict with user-specified CFLAGS. This
change removes the automatic default, allowing users full control
over optimization flags via CFLAGS without unexpected conflicts.

bobzinin requested review from AA-Turner, corona10, emmatyping and erlend-aasland as code owners December 1, 2025 18:34

bedevere-app Bot commented Dec 1, 2025

Copy link Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app Bot mentioned this pull request Dec 1, 2025

subprocess.communicate() doesn't close pipes on Windows #54972

Closed

bedevere-app Bot added the awaiting review label Dec 1, 2025

bobzinin changed the title ~~gh-54972: Remove default OPT=-O for non-GCC compilers~~ Dec 1, 2025

bedevere-app Bot mentioned this pull request Dec 1, 2025

configure shouldn't set a default OPT #54872

Open

python-cla-bot Bot commented Dec 1, 2025 •

edited

Loading

Copy link Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot commented Dec 1, 2025

Copy link Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

StanFromIreland commented Dec 1, 2025

Copy link Copy Markdown

Member

You need to run make regen-configure.

bedevere-app Bot commented Dec 1, 2025

Copy link Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bobzinin force-pushed the fix-opt-default branch from 98956c5 to cd68588 Compare December 1, 2025 19:22

bedevere-app Bot commented Dec 1, 2025

Copy link Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.


          Remove default OPT=-O for non-GCC compilers

6dc8463

bobzinin force-pushed the fix-opt-default branch from cd68588 to 6dc8463 Compare December 2, 2025 08:17

bedevere-app Bot commented Dec 2, 2025

Copy link Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

github-actions Bot commented May 2, 2026

Copy link Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label May 2, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

corona10 Awaiting requested review from corona10 corona10 is a code owner

AA-Turner AA-Turner is a code owner

emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

Milestone

No milestone