◐ Shell
reader mode source ↗
Skip to content

GH-65961: Stop setting __cached__ on modules#142165

Merged
brettcannon merged 4 commits into
python:mainfrom
brettcannon:remove-__cached__
Dec 11, 2025
Merged

GH-65961: Stop setting __cached__ on modules#142165
brettcannon merged 4 commits into
python:mainfrom
brettcannon:remove-__cached__

Conversation

@brettcannon

@brettcannon brettcannon commented Dec 1, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Dec 1, 2025
Open
@brettcannon brettcannon mentioned this pull request Dec 1, 2025
Open
@brettcannon brettcannon self-assigned this Dec 2, 2025
Hide details View details @brettcannon brettcannon merged commit af18572 into python:main Dec 11, 2025
118 of 124 checks passed
@brettcannon brettcannon deleted the remove-__cached__ branch December 11, 2025 19:44
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 12, 2025
@brettcannon @fatelei
pythonGH-65961: Stop setting __cached__ on modules (pythonGH-142165)
e37ed22
DimitriPapadopoulos
DimitriPapadopoulos reviewed Feb 26, 2026
View reviewed changes

@DimitriPapadopoulos DimitriPapadopoulos left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

@brettcannon This change puts the __cached__ deprecation notices under the __file__ attribute. I find this confusing::

Image

@brettcannon

brettcannon commented Feb 27, 2026

Copy link
Copy Markdown
Member Author

This change puts the __cached__ deprecation notices under the __file__ attribute. I find this confusing

That's a syntax mistake in the docs. Can you please open an issue?

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Feb 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FFY00 FFY00 FFY00 is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

1 more reviewer

@DimitriPapadopoulos DimitriPapadopoulos

Reviewers whose approvals may not affect merge requirements

Assignees

@brettcannon brettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brettcannon @DimitriPapadopoulos