◐ Shell
reader mode source ↗
Skip to content

[3.13] gh-141004: Add a CI job ensuring that new C APIs include documentation (GH-142102)#142248

Merged
ZeroIntensity merged 4 commits into
python:3.13from
ZeroIntensity:backport-1a7824a-3.13
Dec 15, 2025
Merged

[3.13] gh-141004: Add a CI job ensuring that new C APIs include documentation (GH-142102)#142248
ZeroIntensity merged 4 commits into
python:3.13from
ZeroIntensity:backport-1a7824a-3.13

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Dec 4, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit 1a7824a)

ZeroIntensity and others added 2 commits December 3, 2025 22:58
@ZeroIntensity @hugovk
pythongh-141004: Add a CI job ensuring that new C APIs include docume… …
aa0d658 
…ntation (pythonGH-142102)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
(cherry picked from commit 1a7824a)
@ZeroIntensity @hugovk
[3.13] pythongh-141004: Add a CI job ensuring that new C APIs include… …
9345940 
… documentation (pythonGH-142102)

(cherry picked from commit 1a7824a)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This was referenced Dec 4, 2025
Open
Merged
@ZeroIntensity

ZeroIntensity commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

See #142247 (comment).

@ZeroIntensity ZeroIntensity marked this pull request as draft December 4, 2025 04:06
@ZeroIntensity

ZeroIntensity commented Dec 4, 2025

Copy link
Copy Markdown
Member Author

@hugovk Quick question -- it seems CI on 3.13 uses Python 3.12, not 3.13. Is that intentional? If so, I need to remove the use of _colorize here on 3.13.

@hugovk

hugovk commented Dec 8, 2025

Copy link
Copy Markdown
Member

Hmm, well we're installing 3.x in this job, which right now is 3.14:

https://github.com/ZeroIntensity/cpython/blob/backport-1a7824a-3.13/.github/workflows/build.yml#L152-L154

However, for the 3.14 branch, when we run configure:

https://github.com/ZeroIntensity/cpython/blob/93459405c92cb5d275bf310b1d5d1dc43967cfdc/.github/workflows/build.yml#L164

We get:

checking for python3.14... python3.14
checking Python for regen version... Python 3.14.0

But on this 3.13 branch, for some reason we get:

checking for python3.13... no
checking for python3.13... no
checking for python3.12... python3.12
checking Python for regen version... Python 3.12.3

I'm not sure why configure is selecting 3.12...

@ZeroIntensity

ZeroIntensity commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

Do you know if the configure script on 3.13 checks for 3.14? I think that might be the problem. I'm guessing that Python 3.12 is already installed on the system the CI job is running on, and actions/setup-python installs 3.14, which isn't detected by the configure script, so it falls back to 3.12.

@hugovk

hugovk commented Dec 9, 2025

Copy link
Copy Markdown
Member

Do you know if the configure script on 3.13 checks for 3.14?

No, it only checks the current version and lower.

main:

cpython/configure

Line 3828 in 756e7d1

for ac_prog in python$PACKAGE_VERSION python3.15 python3.14 python3.13 python3.12 python3.11 python3.10 python3 python

3.14:

cpython/configure

Line 3820 in f200776

for ac_prog in python$PACKAGE_VERSION python3.15 python3.14 python3.13 python3.12 python3.11 python3.10 python3 python

3.13:

cpython/configure

Line 3765 in b57d695

for ac_prog in python$PACKAGE_VERSION python3.13 python3.12 python3.11 python3.10 python3 python

I think that might be the problem. I'm guessing that Python 3.12 is already installed on the system the CI job is running on, and actions/setup-python installs 3.14, which isn't detected by the configure script, so it falls back to 3.12.

Yes, that indeed looks like the problem.

Here's a test workflow that installs a give version, then tries to check for them all:

          python3.15 --version --version || true
          python3.14 --version --version || true
          python3.13 --version --version || true
          python3.12 --version --version || true
          python3.11 --version --version || true
          python3.10 --version --version || true

And they all have the given version, plus 3.12. For example with 3.15:

Python 3.15.0a2 (main, Nov 19 2025, 15:10:47) [GCC 13.3.0]
/home/runner/work/_temp/9872e36d-a21e-4c3e-8aa1-e6d8f6781c42.sh: line 2: python3.14: command not found
/home/runner/work/_temp/9872e36d-a21e-4c3e-8aa1-e6d8f6781c42.sh: line 3: python3.13: command not found
Python 3.12.3 (main, Nov  6 2025, 13:44:16) [GCC 13.3.0]
/home/runner/work/_temp/9872e36d-a21e-4c3e-8aa1-e6d8f6781c42.sh: line 5: python3.11: command not found
/home/runner/work/_temp/9872e36d-a21e-4c3e-8aa1-e6d8f6781c42.sh: line 6: python3.10: command not found

And it's an old 3.12.3 baked into the image, because when we specifically ask for 3.12 we get the newest 3.12.12:

/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 1: python3.15: command not found
/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 2: python3.14: command not found
/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 3: python3.13: command not found
Python 3.12.12 (main, Oct 10 2025, 01:01:16) [GCC 13.3.0]
/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 5: python3.11: command not found
/home/runner/work/_temp/5205e491-dc12-4355-bc92-e4fd7a15bf8a.sh: line 6: python3.10: command not found

@ZeroIntensity ZeroIntensity mentioned this pull request Dec 9, 2025
Closed
@ZeroIntensity

ZeroIntensity commented Dec 9, 2025

Copy link
Copy Markdown
Member Author

Thanks, I created an issue: #142457

@ZeroIntensity ZeroIntensity marked this pull request as ready for review December 15, 2025 02:42
Hide details View details @ZeroIntensity ZeroIntensity merged commit 5569ffe into python:3.13 Dec 15, 2025
40 checks passed
@ZeroIntensity ZeroIntensity deleted the backport-1a7824a-3.13 branch December 15, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZeroIntensity @hugovk