◐ Shell
reader mode source ↗
Skip to content

gh-142787: Fix assertion failure in sqlite3 blob slice#142824

Merged
erlend-aasland merged 5 commits into
python:mainfrom
abdoulrasheed:fix-issue-142787
Feb 26, 2026
Merged

gh-142787: Fix assertion failure in sqlite3 blob slice#142824
erlend-aasland merged 5 commits into
python:mainfrom
abdoulrasheed:fix-issue-142787

Conversation

@abdoulrasheed

@abdoulrasheed abdoulrasheed commented Dec 16, 2025 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Dec 16, 2025
Closed
@bedevere-app bedevere-app Bot added the label Dec 16, 2025
@erlend-aasland

erlend-aasland commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Thanks for working on this! Please make sure this regression is covered by the test suite.

@erlend-aasland erlend-aasland self-assigned this Dec 16, 2025
@aisk

aisk commented Dec 16, 2025

Copy link
Copy Markdown
Member

Hi, there is a duplicated news entry, please remove it.

@erlend-aasland

erlend-aasland commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Moreover, please avoid force-pushing (as recommended by the devguide).

@abdoulrasheed

abdoulrasheed commented Dec 16, 2025

Copy link
Copy Markdown
Contributor Author

Moreover, please avoid force-pushing (as recommended by the devguide).

Noted @erlend-aasland

@abdoulrasheed

abdoulrasheed commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

@aisk Gentle reminder on this

@aisk

aisk commented Jan 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Let's wait for @erlend-aasland's review.

serhiy-storchaka
serhiy-storchaka approved these changes Jan 9, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM. 👍

@erlend-aasland erlend-aasland enabled auto-merge (squash) February 26, 2026 23:19
@erlend-aasland erlend-aasland linked an issue Feb 26, 2026 that may be closed by this pull request
assertion failure at Modules/_sqlite/blob.c:146: PyObject *read_multiple(pysqlite_Blob *, Py_ssize_t, Py_ssize_t): Assertion 'offset < sqlite3_blob_bytes(self->blob)' failed #142787
Closed
Hide details View details @erlend-aasland erlend-aasland merged commit 06b0920 into python:main Feb 26, 2026
47 checks passed
@miss-islington-app

miss-islington-app Bot commented Feb 26, 2026

Copy link
Copy Markdown

Thanks @abdoulrasheed for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 26, 2026
@abdoulrasheed @miss-islington
pythongh-142787: Handle empty sqlite3 blob slices (pythonGH-142824) …
04cab0e 
(cherry picked from commit 06b0920)

Co-authored-by: A.Ibrahim <abdulrasheedibrahim47@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 26, 2026
@abdoulrasheed @miss-islington
pythongh-142787: Handle empty sqlite3 blob slices (pythonGH-142824) …
de537f0 
(cherry picked from commit 06b0920)

Co-authored-by: A.Ibrahim <abdulrasheedibrahim47@gmail.com>
@bedevere-app

bedevere-app Bot commented Feb 26, 2026

Copy link
Copy Markdown

GH-145297 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Feb 26, 2026
@bedevere-app

bedevere-app Bot commented Feb 26, 2026

Copy link
Copy Markdown

GH-145298 is a backport of this pull request to the 3.13 branch.

erlend-aasland pushed a commit that referenced this pull request Feb 27, 2026
@miss-islington @abdoulrasheed
[3.14] gh-142787: Handle empty sqlite3 blob slices (GH-142824) (#145297) …
bc6a7a2 
(cherry picked from commit 06b0920)

Co-authored-by: A.Ibrahim <abdulrasheedibrahim47@gmail.com>
erlend-aasland pushed a commit that referenced this pull request Feb 27, 2026
@miss-islington @abdoulrasheed
[3.13] gh-142787: Handle empty sqlite3 blob slices (GH-142824) (#145298) …
cd3e9b3 
(cherry picked from commit 06b0920)

Co-authored-by: A.Ibrahim <abdulrasheedibrahim47@gmail.com>
brijkapadia pushed a commit to brijkapadia/cpython that referenced this pull request Feb 28, 2026
@abdoulrasheed @brijkapadia
pythongh-142787: Handle empty sqlite3 blob slices (python#142824)
26a469c
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@abdoulrasheed @ljfp
pythongh-142787: Handle empty sqlite3 blob slices (python#142824)
9fbeae8
@ever0de ever0de mentioned this pull request May 26, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag

Assignees

@erlend-aasland erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@abdoulrasheed @erlend-aasland @aisk @serhiy-storchaka