{{ message }}
gh-142927: Tachyon: Fix contrast ratio in top panel#142936
Merged
pablogsal merged 3 commits intoDec 25, 2025
Merged
Conversation
pablogsal
approved these changes
Dec 18, 2025
Member
|
This also affects the flamegraph output. |
Sorry, something went wrong.
Member
Author
In what way? For better, or worse? Please share more details. |
Sorry, something went wrong.
Member
|
As in, the CSS is copy-pasted: cpython/Lib/profiling/sampling/_flamegraph_assets/flamegraph.css Lines 349 to 352 in 14f0b51 |
Sorry, something went wrong.
Member
Author
Sorry, something went wrong.
Hide details
View details
pablogsal
merged commit
ea3fd78
into
python:main
Dec 25, 2025
44 checks passed
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.




Before
In dark mode, the samples/sec numbers has contrast ratio of 2.9.
In light mode, duration and missed samples are 1.63 and 2.15 respectively.
They should be at least 4.5 to meet WCAG AA guidelines.
After
The values suggested by Chrome: