gh-120321: Avoid -Wunreachable-code warning on Clang#143022
Conversation
|
I hate this, but I hate the other options even more. |
Sorry, something went wrong.
mpage
left a comment
There was a problem hiding this comment.
We'll end up seeing the warning if clang's analysis gets more capable, right? I guess that's still better than disabling warnings around the block in the default build.
Test failure looks unrelated.
Sorry, something went wrong.
I think it's more a matter of convention than capability. Clang can easily optimize through all these things and this warning is only enabled in optimized builds (not debug builds). Clang doesn't warn for things like: But it warns for: But not for: But you can't put that expression in a macro: |
Sorry, something went wrong.
7607712
into
python:main
Dec 20, 2025
edited by bedevere-app
Bot
LoadingUh oh!
There was an error while loading. Please reload this page.
Copy link Copy MarkdownSorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.