◐ Shell
reader mode source ↗
Skip to content

gh-130796: Undeprecate locale.getdefaultlocale()#143069

Merged
vstinner merged 4 commits into
python:mainfrom
vstinner:undeprecate_getdefaultlocale
Dec 23, 2025
Merged

gh-130796: Undeprecate locale.getdefaultlocale()#143069
vstinner merged 4 commits into
python:mainfrom
vstinner:undeprecate_getdefaultlocale

Conversation

@vstinner

@vstinner vstinner commented Dec 22, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Dec 22, 2025
Closed
@hugovk

hugovk commented Dec 22, 2025

Copy link
Copy Markdown
Member

Should we note the undeprecation in What's New?

Let's also remove/update in Doc/deprecations/pending-removal-in-3.15.rst

@StanFromIreland

StanFromIreland commented Dec 22, 2025

Copy link
Copy Markdown
Member

I think adding a news entry makes sense, it may cause confusion now when one searches the changelog, and sees it is deprecated with no un-deprecation note.

@vstinner
Add NEWS entry …
bca57e7 
Update Doc/deprecations/pending-removal-in-3.15.rst.
@vstinner
Add What's New entry
7e36d09
@vstinner vstinner requested a review from AA-Turner as a code owner December 23, 2025 10:45
@vstinner

vstinner commented Dec 23, 2025

Copy link
Copy Markdown
Member Author

@hugovk @StanFromIreland: I added What's New and NEWS entries. Please review the updated change.

hugovk
hugovk approved these changes Dec 23, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks.

StanFromIreland
StanFromIreland approved these changes Dec 23, 2025
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM

Hide details View details @vstinner vstinner merged commit 6536fab into python:main Dec 23, 2025
87 of 89 checks passed
@vstinner vstinner deleted the undeprecate_getdefaultlocale branch December 23, 2025 15:31
This was referenced Jun 11, 2026
Closed
Closed
@hugovk

hugovk commented Jun 11, 2026

Copy link
Copy Markdown
Member

Re: #90817 (comment), let's backport.

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 11, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6536fab19410ce701575b553d381cf805d3ef323 3.13

@miss-islington-app

miss-islington-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6536fab19410ce701575b553d381cf805d3ef323 3.14

@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151317 is a backport of this pull request to the 3.14 branch.

@bedevere-app

bedevere-app Bot commented Jun 11, 2026

Copy link
Copy Markdown

GH-151318 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 11, 2026
hugovk added a commit that referenced this pull request Jun 11, 2026
@hugovk @vstinner
[3.14] gh-130796: Undeprecate locale.getdefaultlocale() (GH-143069) (#… …
58c6e78 
…151317)

Co-authored-by: Victor Stinner <vstinner@python.org>
hugovk added a commit that referenced this pull request Jun 11, 2026
@hugovk @vstinner
[3.13] gh-130796: Undeprecate locale.getdefaultlocale() (GH-143069) (#… …
06dce35 
…151318)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @hugovk @StanFromIreland