◐ Shell
reader mode source ↗
Skip to content

gh-141004: Document unstable perf map functions in ceval.h#143492

Merged
ZeroIntensity merged 8 commits into
python:mainfrom
Yashp002:doc-ceval-perf
Jun 3, 2026
Merged

gh-141004: Document unstable perf map functions in ceval.h#143492
ZeroIntensity merged 8 commits into
python:mainfrom
Yashp002:doc-ceval-perf

Conversation

@Yashp002

@Yashp002 Yashp002 commented Jan 6, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

gh-141004: Document unstable perf map functions in ceval.h

This PR documents the PyUnstable_CopyPerfMapFile, PyUnstable_PerfTrampoline_CompileCode, and PyUnstable_PerfTrampoline_SetPersistAfterFork functions in Doc/c-api/perfmaps.rst.

📚 Documentation preview 📚: https://cpython-previews--143492.org.readthedocs.build/

@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Jan 6, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jan 6, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jan 6, 2026
Open
@encukou encukou mentioned this pull request Jan 7, 2026
Merged
ZeroIntensity
ZeroIntensity reviewed Jan 8, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Please update Tools/check-c-api-docs/ignored_c_api.txt as well.

@Yashp002

Yashp002 commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

@encukou , @ZeroIntensity

Docs unrelated to test failure

Tests / Windows (free-threading) / Build and test (arm64) (pull_request),Failing after 24m:

testexternalinspection.testcacheperthreadisolation fails in free-threading
ARM64 Windows CI (pre-existing).

@Yashp002 Yashp002 mentioned this pull request Jan 8, 2026
Open
@Yashp002

Yashp002 commented Jan 17, 2026

Copy link
Copy Markdown
Contributor Author

@encukou @StanFromIreland
Could you guide me if there are further changes needed with this PR?

encukou
encukou reviewed Jan 30, 2026
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I asked some more questions. Could you go through the unresolved comments here?

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 4, 2026
11 hidden items Load more…
@read-the-docs-community

read-the-docs-community Bot commented Jun 3, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #32971943 | 📁 Comparing ba3e3cf against main (5553e00)

  🔍 Preview build  

2 files changed
± c-api/perfmaps.html
± whatsnew/changelog.html

ZeroIntensity
ZeroIntensity approved these changes Jun 3, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

I don't see any more blocking issues here -- let's get these documented!

If anyone disagrees with anything here, or otherwise want to make some change to the test, feel free to send a follow-up and tag me on it.

@ZeroIntensity ZeroIntensity enabled auto-merge (squash) June 3, 2026 12:33
@ZeroIntensity ZeroIntensity added needs backport to 3.13 needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed stale Stale PR or inactive for long period of time. labels Jun 3, 2026
Hide details View details @ZeroIntensity ZeroIntensity merged commit 6453065 into python:main Jun 3, 2026
51 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jun 3, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 3, 2026

Copy link
Copy Markdown

Thanks @Yashp002 for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Jun 3, 2026

Copy link
Copy Markdown

Sorry, @Yashp002 and @ZeroIntensity, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6453065db9ff31e3f737240030f8311d2b087851 3.14

@bedevere-app

bedevere-app Bot commented Jun 3, 2026

Copy link
Copy Markdown

GH-150849 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 3, 2026
@miss-islington-app

miss-islington-app Bot commented Jun 3, 2026

Copy link
Copy Markdown

Sorry, @Yashp002 and @ZeroIntensity, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6453065db9ff31e3f737240030f8311d2b087851 3.13

ZeroIntensity pushed a commit that referenced this pull request Jun 3, 2026
@miss-islington @Yashp002
[3.15] gh-141004: Document unstable perf map functions in ceval.h (G… …
0f08c55 
…H-143492) (GH-150849)

gh-141004: Document unstable perf map functions in `ceval.h` (GH-143492)
(cherry picked from commit 6453065)

Co-authored-by: Yashraj <yashrajpala8@gmail.com>
philthompson10 pushed a commit to philthompson10/cpython that referenced this pull request Jun 17, 2026
@Yashp002 @philthompson10
pythongh-141004: Document unstable perf map functions in ceval.h (p… …
c605ffe 
…ythonGH-143492)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

@encukou encukou encukou left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@StanFromIreland StanFromIreland

Assignees

@ZeroIntensity ZeroIntensity

Labels

docs Documentation in the Doc dir needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Yashp002 @vstinner @encukou @ZeroIntensity @StanFromIreland