◐ Shell
reader mode source ↗
Skip to content

gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed#143583

Merged
ZeroIntensity merged 4 commits into
python:mainfrom
StanFromIreland:ignore-capi-tests
Jan 13, 2026
Merged

gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed#143583
ZeroIntensity merged 4 commits into
python:mainfrom
StanFromIreland:ignore-capi-tests

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jan 8, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Jan 8, 2026
Open
@StanFromIreland StanFromIreland mentioned this pull request Jan 8, 2026
Open
@StanFromIreland

StanFromIreland commented Jan 9, 2026

Copy link
Copy Markdown
Member Author

@hugovk maybe you could please take a look?

ZeroIntensity
ZeroIntensity approved these changes Jan 9, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thanks, I'm fine with this. Since it's right before the weekend, I'll give others a few more days to take a look before merging.

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 9, 2026
@hugovk

hugovk commented Jan 10, 2026

Copy link
Copy Markdown
Member

Idle thought, we could write:

if not (doc_file or file in RUN_TESTS_IGNORE):

As:

if not doc_file and file not in RUN_TESTS_IGNORE:

I think that's a little clearer?

An unrelated condition that could be made clearer in this file is:

        if not has_platform_specific_change or not platforms_changed:
            a
        else:
            b

Is the same as:

        if not (has_platform_specific_change and platforms_changed):
            a
        else:
            b

And flip to put the positive first:

        if has_platform_specific_change and platforms_changed:
            b
        else:
            a

Hide details View details @ZeroIntensity ZeroIntensity merged commit 1176fac into python:main Jan 13, 2026
53 checks passed
@miss-islington-app

miss-islington-app Bot commented Jan 13, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2026
@StanFromIreland @miss-islington
pythongh-141004: Don't trigger run-tests when `Tools/check-c-api-do… …
6b00baf 
…cs/ignored_c_api.txt` is changed (pythonGH-143583)

(cherry picked from commit 1176fac)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2026
@StanFromIreland @miss-islington
pythongh-141004: Don't trigger run-tests when `Tools/check-c-api-do… …
bdf3b2a 
…cs/ignored_c_api.txt` is changed (pythonGH-143583)

(cherry picked from commit 1176fac)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Jan 13, 2026

Copy link
Copy Markdown

GH-143793 is a backport of this pull request to the 3.14 branch.

@bedevere-app

bedevere-app Bot commented Jan 13, 2026

Copy link
Copy Markdown

GH-143794 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jan 13, 2026
@StanFromIreland StanFromIreland deleted the ignore-capi-tests branch January 13, 2026 13:32
ZeroIntensity pushed a commit that referenced this pull request Jan 13, 2026
@miss-islington @StanFromIreland
[3.13] gh-141004: Don't trigger run-tests when `Tools/check-c-api-d… …
0770c78 
…ocs/ignored_c_api.txt` is changed (GH-143583) (GH-143794)

gh-141004: Don't trigger `run-tests` when `Tools/check-c-api-docs/ignored_c_api.txt` is changed (GH-143583)
(cherry picked from commit 1176fac)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
ZeroIntensity pushed a commit that referenced this pull request Jan 13, 2026
@miss-islington @StanFromIreland
[3.14] gh-141004: Don't trigger run-tests when `Tools/check-c-api-d… …
a705f57 
…ocs/ignored_c_api.txt` is changed (GH-143583) (GH-143793)

gh-141004: Don't trigger `run-tests` when `Tools/check-c-api-docs/ignored_c_api.txt` is changed (GH-143583)
(cherry picked from commit 1176fac)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@StanFromIreland @thunder-coding
pythongh-141004: Don't trigger run-tests when `Tools/check-c-api-do… …
91c48b0 
…cs/ignored_c_api.txt` is changed (pythonGH-143583)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk

@ZeroIntensity ZeroIntensity

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @hugovk @ZeroIntensity