{{ message }}
gh-143939: Fix assignment to _PyThreadStateImpl.generator_return_kind#143951
Merged
colesbury merged 2 commits intoJan 20, 2026
Merged
gh-143939: Fix assignment to _PyThreadStateImpl.generator_return_kind#143951colesbury merged 2 commits into
_PyThreadStateImpl.generator_return_kind#143951colesbury merged 2 commits into
Conversation
Contributor
Sorry, something went wrong.
…n_kind The assignment to generator_return_kind has to be after any potentially escaping calls or it might be overwritten.
johnslavik
reviewed
Jan 17, 2026
johnslavik
approved these changes
Jan 17, 2026
kumaraditya303
approved these changes
Jan 17, 2026
kumaraditya303
left a comment
kumaraditya303
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
10 tasks
Hide details
View details
colesbury
merged commit
colesbury
merged commit 43bb630
into
python:main
Jan 20, 2026
53 checks passed
thunder-coding
pushed a commit
to thunder-coding/cpython
that referenced
this pull request
Feb 15, 2026
…rn_kind` (pythongh-143951) The assignment to generator_return_kind has to be after any potentially escaping calls to ensure that it's not overwritten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
The assignment to generator_return_kind must be after any potentially escaping calls to ensure that it's not overwritten.