◐ Shell
reader mode source ↗
Skip to content

bpo-36511: clean up python process before deploy#14431

Merged
zware merged 1 commit into
python:masterfrom
paulmon:clean_python_exe
Sep 9, 2019
Merged

bpo-36511: clean up python process before deploy#14431
zware merged 1 commit into
python:masterfrom
paulmon:clean_python_exe

Conversation

@paulmon

@paulmon paulmon commented Jun 27, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

If the previous buildbot test times out, there will be orphaned python processes that prevent deploy from working. Kill python.exe processes before trying to clean remote test directory

@zooba @zware

https://bugs.python.org/issue36511

zware
zware approved these changes Sep 9, 2019
View reviewed changes

@zware zware left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

LGTM, provided that the kill command exists :). I may be operating from out of date information, but I thought Windows only offered taskkill /IM python.exe?

@zooba

zooba commented Sep 9, 2019

Copy link
Copy Markdown
Member

Agreed with Zachary - "kill" isn't a Windows cmd.exe command (it is an alias in PowerShell), and I'm pretty sure you've only got cmd.exe commands at the other end of the SSH connection (since dir /b won't work in PowerShell).

Unless it's a new/extra addition on the buildbot?

@paulmon

paulmon commented Sep 9, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

kill.exe is a command on Windows IoT Core which is what the buildbot is running.
There is no taskkill.exe on Windows IoT Core.
I haven't seen this problem occur since I made this PR.
The last time the arm32 worker machine was producing bad results (stack overflow test kept failing)
because it was unhealthy a reboot was required to recover it.

@zware zware added the skip news label Sep 9, 2019
@zware

zware commented Sep 9, 2019

Copy link
Copy Markdown
Member

Ok, we'll give this a try then.

@zware zware merged commit 55d12ce into python:master Sep 9, 2019
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@paulmon @websurfer5
bpo-36511: clean up python process before deploy on ARM Windows build… …
5de360e 
…bots (pythonGH-14431)
@paulmon paulmon mannequin mentioned this pull request May 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paulmon @zooba @zware @the-knights-who-say-ni @bedevere-bot