◐ Shell
reader mode source ↗
Skip to content

gh-144145: Cleanups for object property tracking in JIT optimizer#144366

Closed
Fidget-Spinner wants to merge 4 commits into
python:mainfrom
Fidget-Spinner:gh-144145-fixups
Closed

gh-144145: Cleanups for object property tracking in JIT optimizer#144366
Fidget-Spinner wants to merge 4 commits into
python:mainfrom
Fidget-Spinner:gh-144145-fixups

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jan 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

So the previous PR set a good foundation and was always right as it depends on a runtime check. However, I just noticed some bugs that need cleanup:

  1. we can do better and eliminate the DEOPT_IF(attr != NULL) completely
  2. There's a bug with dealing with escapes. I added a test for that.

@bedevere-app bedevere-app Bot mentioned this pull request Jan 31, 2026
Closed
@Fidget-Spinner

Fidget-Spinner commented Jan 31, 2026

Copy link
Copy Markdown
Member Author

@cocolato can you review this please?

@cocolato

cocolato commented Feb 1, 2026

Copy link
Copy Markdown
Member

Sorry for any undiscovered bugs, thanks for the fix!

@cocolato

cocolato commented Feb 1, 2026

Copy link
Copy Markdown
Member

Thanks, LGTM.

@Fidget-Spinner

Fidget-Spinner commented Feb 1, 2026

Copy link
Copy Markdown
Member Author

Thanks, LGTM.

Thanks! Please approve, and I will merge.

@cocolato

cocolato commented Feb 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks! Please approve, and I will merge.

Sorry, I don't have approve permission.

@markshannon markshannon mentioned this pull request Feb 2, 2026
Merged
@cocolato

cocolato commented Feb 2, 2026

Copy link
Copy Markdown
Member

It should close after we revert #144122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

@cocolato cocolato Awaiting requested review from cocolato

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Fidget-Spinner @cocolato